[jbosstools-dev] freemarker repo weirdness..? nexus broken ?

[Nick Boldt]

OK, so let me restate my assessment:

The parent pom we used to build pointed at the 4.4x.0.Final-SNAPSHOT 
target platforms, which are identical to the 4.4x.0.Final ones, so no 
foul occurred.

The parent pom should have been rebuilt AFTER releasing the target 
platforms. We updated the code [0] but didn't actually rebuild the 
parent, so it still pointed at the -SNAPSHOT version, not the released one.

[0] 
https://github.com/jbosstools/jbosstools-build/commit/da9599c5800b01529eca745e578cde640f7eb5e8

Hence the error reported was:

[ERROR] Internal error: java.lang.RuntimeException: Could not resolve 
target platform specification artifact 
org.jboss.tools.targetplatforms:jbosstools-unified:target:jbosstools-unified:4.40.0.Final-SNAPSHOT

Had we rebuilt the parent pom after releasing the TPs, the user would 
have instead tried to download target platform specification artifact 
org.jboss.tools.targetplatforms:jbosstools-unified:target:jbosstools-unified:4.40.0.Final 
(not -SNAPSHOT).

As we can see from 
https://repository.jboss.org/nexus/content/repositories/snapshots/org/jboss/tools/parent/4.2.0.Final-SNAPSHOT/parent-4.2.0.Final-20141015.125413-1.pom 
(which is the version built on Oct 15, 2014 8:53:50 AM, build #40), the 
target platform reference is to

<TARGET_PLATFORM_VERSION>4.40.0.Final-SNAPSHOT</TARGET_PLATFORM_VERSION>
<TARGET_PLATFORM_VERSION_MAXIMUM>4.41.0.Final-SNAPSHOT</TARGET_PLATFORM_VERSION_MAXIMUM>

But when we look at the rebuilt version from Nov 12 (#41) [1], we see 
the corrected code:

<TARGET_PLATFORM_VERSION>4.40.0.Final</TARGET_PLATFORM_VERSION>
<TARGET_PLATFORM_VERSION_MAXIMUM>4.41.0.Final</TARGET_PLATFORM_VERSION_MAXIMUM>

[1] 
https://repository.jboss.org/nexus/content/repositories/snapshots/org/jboss/tools/parent/4.2.0.Final-SNAPSHOT/parent-4.2.0.Final-20141112.233742-2.pom

So... as I said before, the solution was to rebuild the parent pom for 
external contributors to use. I was wrong about the nexus purge, however.

Nick


On 11/13/2014 11:29 AM, Max Rydahl Andersen wrote:
> On 13 Nov 2014, at 16:17, Nick Boldt wrote:
>
>> "But why was that needed ?"
>>
>> Because Nexus periodically purges snapshots. So we rebuild them.
>
> The parent snapshot was not missing so I don't see how rebuilding the
> parent pom snapshot because it was purge is the right explanation.
>
> I looks like the parent that was present was pointing to a target
> platform snapshot which is gone which of course
> gets lost because we released a final version of the TP, right ?
>
>> Simple problem, simple solution. This happens all the dang time,
>> usually at inopportune moments (like right before a milestone
>> release). But it's trivial to fix, and the longer solution is "ask
>> eng-ops to stop purging snapshots" to which they'll say "disk isn't
>> free".
>
> The parent snapshot was not missing so I still question that something
> else must have gone wrong.
>
> Seems like our parent pom was not actually correct. Which is not an
> eng-ops or purging issue but something being wrong in our handling of
> the parent pom
> and its usage of target platform.
>
> How can we avoid that in the future contributors and our selfs does not
> actually have an outofdate parent pom especially when we just did a
> final release ?
> /max
>
>> N
>>
>> On 11/12/2014 07:07 PM, Max Rydahl Andersen wrote:
>>> On 12 Nov 2014, at 0:00, Denis Golovin wrote:
>>>
>>>> On 11/11/2014 01:00 PM, Max Rydahl Andersen wrote:
>>>>> On 11 Nov 2014, at 21:55, Denis Golovin wrote:
>>>>>
>>>>>> Tried on master, it failed because of missing reference to base
>>>>>> nightly repository.
>>>>>> So I fixed it and it now works OOTB.
>>>>>>
>>>>>> Questions is why does it works fine on jenkins? Seems somehow
>>>>>> nightly aggregate is available in jenkins build, that's why
>>>>>> freemarker build can resolve usage and tests components it depends
>>>>>> on.
>>>>>
>>>>> That would be bad if that is the case ;/ ...but I'm pretty sure I
>>>>> have been building freemarker from mvn cli before...wondering what
>>>>> changed.
>>>>>
>>>>> Michael/Nick - any idea ?
>>>>>
>>>>> Denis - if you got solution let the contributor know on #26 (I can't
>>>>> test/verify from here right now)
>>>
>>> something is really fishy here.
>>>
>>> now 4.2.x in freemarker is building.
>>>
>>> Nick writes on
>>> https://github.com/jbosstools/jbosstools-freemarker/issues/26#issuecomment-62815793
>>>
>>> that parent pom is now built again.
>>>
>>> But why was that needed ? we just did  a release that used this and that
>>> snapshot version should not change from now on.
>>>
>>> Would need  a 4.2.1.Final for changes.
>>>
>>> ...does this mean the 4.2.0.Final-SNAPSHOT that was available for all to
>>> use until today was broken/outofdate ?
>>>
>>> /max
>>>
>>>>>
>>>>> /max
>>>>
>>>> Yes, I fixed master and post my comment in issues/26.
>>>>
>>>> Denis
>>>>
>>>>>
>>>>>> Denis
>>>>>>
>>>>>> On 11/11/2014 05:04 PM, Max Rydahl Andersen wrote:
>>>>>>> Hey,
>>>>>>>
>>>>>>> Freemarker repo is not buildable anymore.
>>>>>>>
>>>>>>> User at
>>>>>>> https://github.com/jbosstools/jbosstools-freemarker/issues/26
>>>>>>> having issues
>>>>>>> and I can verify the issue but my quick look indicates the right
>>>>>>> versions are used but
>>>>>>> the build is for sure broken.
>>>>>>>
>>>>>>> Anyone able to spot the missing piece ?
>>>>>>>
>>>>>>> /max
>>>>>>> http://about.me/maxandersen
>>>>>>> _______________________________________________
>>>>>>> jbosstools-dev mailing list
>>>>>>> jbosstools-dev at lists.jboss.org
>>>>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>>
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>
>>
>> --
>> Nick Boldt :: JBoss by Red Hat
>> Productization Lead :: JBoss Tools & Dev Studio
>> http://nick.divbyzero.com
>
>
> /max
> http://about.me/maxandersen

-- 
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com