[jbosstools-dev] [jbosstools-openshift] JBIDE-21175 - ensure more reliable locating of vagrant command (#831)

[Max Rydahl Andersen]

Question relevant on the list. 

/max
http://about.me/maxandersen


> On 08 Dec 2015, at 05:09, Rob Stryker <rob.stryker at jboss.com> wrote:
> 
> Hey Guys:
> 
> Can you clarify how you guys call filesystem commands like npm and cordova? 
> 
> In the CDK tools as currently coded, we do two different things.  One, is that we create an "External Tools Launch Configuration" which runs the command. This requires knowing the actual location of the executable.  The other is to simply call Runtime.exec(etc) and get a Process from it. 
> 
> The external tools launch config is useful because it opens a console for us and means we don't have to do any of the wiring, so we use that when we know we want the commands to be visible to the user. We use the runtime.exec() in the background for commands that we want to run without showing the user (for example if we did a vagrant adbinfo)
> 
> How do you all do it?
> 
> - Rob Stryker
> 
> 
>> On 12/03/2015 11:36 AM, Max Rydahl Andersen wrote:
>> In plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/CDKConstantUtility.java:
>> 
>> >  	public static String getVagrantLocation() {
>> > -		return VAGRANT_LOCATION_LINUX;
>> > +		return findVagrantLocation();
>> im wondering if we are better of launching this similar to what @gercan and @ibuziuk been doing for npm and cordova cli tools.
>> 
>> i.e. call out via bash or cmd.exe making it up to the user to have it properly configured in PATH
>> 
>> —
>> Reply to this email directly or view it on GitHub.
>> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20151208/3b3e97b1/attachment.html