[jbosstools-dev] Question on all external users of IJBoss7ManagerService

[Max Rydahl Andersen]

On 25 Jun 2015, at 18:56, Rob Stryker wrote:

> On 06/25/2015 05:47 AM, Max Rydahl Andersen wrote:
>>
>>> My PR to fix the issue creates a 71x service inside the
>>> org.jboss.ide.eclipse.as.management.wildfly8 to live along side the 
>>> wf8
>>> service. Unfortunately, it seems strange now to have a plugin named
>>> org.jboss.ide.eclipse.as.management.as71 which holds a service with
>>> version=7.1.0.Beta1  which only works for AS 7.0.x  =P   Seems a bit
>>> odd, no?
>>
>> eh - why would as71 not continue to work with AS 7.1, EAP etc. ?
>
> I'm saying that in my PR,   the jars in the as71 management plugin 
> would only work for as70,

Are you somehow going to make it impossible for use the as71 to work for 
others but as70 ?

aren't you just going to start using newer management version with the 
other server adapters ?

i.e. as71 is not changing from how it was before ? it is the as71 client 
jars - that is it; and we choose in our server adapter which one we use 
that fit best - currently that is now the as9.management jars, right ?

> while the jars in the wf8 plugin will work for as71 through wf9.

in the first mail you said it was the wf9 jars that would make it 
better, now you say wf8 ? which one is it ?

> This is pretty confusing, since someone might expect the jars in the 
> as71 plugin are the one being used for as71, which won't be the case.

no, but I do not think this is a problem. the management.as71 means the 
"management jars from as71", right ? Not "the management jars used only 
for as71".

> Of course if a client were using the mgmt plugins properly, they'd 
> have an IServer already, and use the existing API (Extended 
> properties, etc)  to get the management service. But if they're 
> "hand-rolling" their own solution by locating services with specific 
> version strings, or depending on specific plugins, this becomes more 
> of an issue.
>
>
> Ideally I'd like to rename the plugins to match better their 
> functionality.

I never seen them as what their functionality are, but what client jars 
they contain.

Which then are selected by the server adapter to what they want to use ?

> I'd also like to rename the constants to match what they actually work 
> for, so we don't have constants with strings including "beta1" or 
> other such nonesense...   But in order to do this safely, I need to 
> know who our external users are of the IJBoss7ManagerService,  what 
> constants they use, whether they depend on a given plugin name 
> directly (either in their manifests or features), or if they just 
> depend on my AS feature (and then I pull in all the management stuff).

I don't know what those constants are and why we would ever have 
such....you should just go look in teiid designer and fuse tools code 
base - they are afaik the only one using us.

But seems like we are cleaning something up that dont need much cleaning 
up...but seeing the PR could help answer that.

> Basically, I'd like to clean up the code, rename the things that make 
> no sense, and harmonize the situation ;)

show the PR.

For now, your description of management.asXY did not seem to need 
harmonizing afaics - it already is harmonised.


/max
http://about.me/maxandersen