[jbosstools-dev] Can we have a jenkins build triggered upon github PR?

[Max Rydahl Andersen]

> I think it is beyond overkill to even try for b).  wildfly doesn't 
> rebuild and run the test suite for a given change in jasper, for 
> example. The entire idea that not even an actual change, but a 
> potential change / PR, to base, could end up kicking off the entire 
> product build and their associated test suites.  I think this is 
> beyond overkill:  it's dangerous and will sap computing power and lock 
> up slaves doing what's essentially no-ops.

not true - if done right you don't need to rebuild everything you just 
run the test suite again.

> PR's change frequently.  Imagine a change in base that gets a few 
> different revisions?  Suddenly I can't even update my PR to change 
> some text string without it kicking off a potential entire build chain 
> and test suite.

No, it would be kicking of a build chain once you decided you PR gets 
merged into master of your component.

This "B" would not run as often as your "A.

> Not to mention, what if the upstream tests were already failing?

If they did they should be rolled back to not fail. That is the very 
critical difference in approach to what you actually commit into your 
master.

> You'd have to build all the upstream plugins with the OLD base, then 
> build base, build everything, run all the tests, and somehow compare 
> the new test results to the previous test results.

No, you would not need to build everything - you would run the tests 
firsts. Then if need be recompile if broken binary compatibility and 
then yes compare results - this is not new. I did this for systems I 
built 10 years ago - albeit it was not an Eclipse desktop UI.

> I think this is folly, and it should not be pursued at all.
>
> Start with a), and finish with a).

Start with A, lets see where that brings us.

Some kind of B is definitely a requirement if we want to scale to know 
within hours rather than months if we can release.

/max

>>
>> On Tue, Apr 26, 2016 at 6:59 PM, Alexey Kazakov <alkazako at redhat.com> 
>> wrote:
>>> +100 to start with a)
>>>
>>> On 04/26/2016 02:20 PM, Nick Boldt wrote:
>>>> https://issues.jboss.org/browse/JBIDE-21657
>>>>
>>>> On Tue, Apr 26, 2016 at 1:13 PM, Mickael Istria 
>>>> <mistria at redhat.com> wrote:
>>>>> On 04/26/2016 05:50 PM, Max Rydahl Andersen wrote:
>>>>>
>>>>> in other words, start with a
>>>>>
>>>>>> a) does the PR break my tests / want a green light on the PR page
>>>>> +1000. Is there a Jira for that?
>>>>> -- 
>>>>> Mickael Istria
>>>>> Eclipse developer at JBoss, by Red Hat
>>>>> My blog - My Tweets
>>>>>
>>>>> _______________________________________________
>>>>> jbosstools-dev mailing list
>>>>> jbosstools-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>>


> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev


/max
http://about.me/maxandersen