[jbosstools-dev] Migration to jgit timestamps

[Nick Boldt]

Based on tests done in the JIRA, if a plugin changes, the features
that contain it, and any features that contain that feature, are also
upversioned. So I'm happy to write tests for this but seems to be
behaving according to Eclipse/OSGi/Tycho rules already.

I suspect too that the baseline comparator test will catch problems
where things are not correctly upversioned, too.

On Mon, Jul 4, 2016 at 10:10 AM, Max Rydahl Andersen
<manderse at redhat.com> wrote:
> Thanks for verifying Nick and Mickael - so I was correct in it is the
> plugins
> AND features that will change. Not just the plugins.
>
> I would suggest we ensure we add tests for this so we don't miss it, since
> I reckon the feature is also included in a feature that might not be
> automatically
> upversioned ?
>
> /max
>
>
>> Or look at the examples I posted on the JIRA [1] . Because
>> features/com.jboss.devstudio.core.feature/feature.xml contains
>>
>>   <plugin id="com.jboss.devstudio.core.central" download-size="0"
>> install-size="0" version="0.0.0" unpack="false"/>
>>
>> therefore its version is bumped to a newer timestamp every time we
>> edit anything in com.jboss.devstudio.core.central or cause a new
>> version to be produced.
>>
>> [1]
>> https://issues.jboss.org/browse/JBIDE-13671?focusedCommentId=13259284&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13259284
>>
>> On Thu, Jun 30, 2016 at 11:48 AM, Mickael Istria <mistria at redhat.com>
>> wrote:
>>>
>>> On 06/30/2016 05:34 PM, Max Rydahl Andersen wrote:
>>>
>>> This might already be handed by tycho's jgit mechanism but just wanted
>>>
>>> to be sure we didn't state it was just for the plugin if it also
>>> includes
>>> the feature and all up to whatever product feature.
>>>
>>> Yeah, see
>>>
>>> https://wiki.eclipse.org/Tycho/Reproducible_Version_Qualifiers#Feature_version_qualifiers
>>>
>>> --
>>> Mickael Istria
>>> Eclipse developer at JBoss, by Red Hat
>>> My blog - My Tweets
>>>
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>>
>> --
>> Nick Boldt :: JBoss by Red Hat
>> Productization Lead :: JBoss Tools & Dev Studio
>> http://nick.divbyzero.com
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
>
>
> /max
> http://about.me/maxandersen



-- 
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com