[jbosstools-dev] Pull Request against jbosstools-target-platforms repository validated automatically

Max Rydahl Andersen manderse at redhat.com
Tue May 10 04:16:51 EDT 2016


or give a link to a PR to see the results (both with good and bad 
results) ?

/max

> This sounds awesome. Any chance you could screencast or screenshot 
> this workflow ?
>
> /max
>
>> Hi all,
>>
>> With https://issues.jboss.org/browse/JBIDE-22312 , a new CI job [1] 
>> now validates, mirror and runs p2diff [2] automatically whenever a 
>> pull request is submitted against the 
>> jhttps://github.com/jbosstools/jbosstools-target-platforms/ 
>> repository. This automated validation then report its success or 
>> failure on the pull request directly, annotating it like Travis CI 
>> does (with a green or red box depending on success).
>> It returns a failure if TP validation or mirroring fail. It's most 
>> likely to happen because of a wrong reference to a p2 repository, a 
>> missing IU or an incorrect version, or a missing requirement.
>> It returns a successful build if it managed to validate the PR and 
>> mirror its content. In such case, there is still need to follow the 
>> links to the jenkins job have a human look at the p2diff attached to 
>> the build, and to comment whether p2diff looks fine on the PR. Then, 
>> when build is successful and p2diff looks good, the PR can be 
>> announced to the team and considered for a merge.
>>
>> Notes:
>> * p2diff report is now generated automatically on regular Maven build 
>> (even local ones), building the TP with the -Pmultiple2repo profile.
>> * Triggering validation build is setup as a cron running every 5 
>> minutes, so it's fine if the build doesn't start immediately after 
>> your PR creation/update. Just check it again a bit later and in case 
>> of issue, ping @mickaelistria and/or @nickboldt on this PR
>> * The validation build takes about 1 hour. There are for sure 
>> opportunities to speed it up, but as the TP process is slow anyway 
>> and that this approach is already faster than the previous ones 
>> requiring local mirror and p2diff, speeding it up isn't high priority 
>> at the moment.
>>
>> Cheers,
>>
>> [1] 
>> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-target-platform--pull-request/
>> [2] https://issues.jboss.org/browse/JBIDE-22308
>> -- 
>> Mickael Istria
>> Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
>> My blog <http://mickaelistria.wordpress.com> - My Tweets 
>> <http://twitter.com/mickaelistria>
>
>
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
>
> /max
> http://about.me/maxandersen




/max
http://about.me/maxandersen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20160510/513d24b3/attachment.html 


More information about the jbosstools-dev mailing list