[jbosstools-dev] PROPOSAL: parent pom breaking change -- run baseline checks even if -DskipTests=true

[Nick Boldt]

Thanks to those who've commented in
https://issues.jboss.org/browse/JBIDE-24114 so far. Seems to be a
single -1 and a few +1s.

Any more feedback?

I'll apply this change in the next couple days unless more negative
impacts are discovered.

Thanks,

Nick

On Fri, Mar 17, 2017 at 10:34 AM, Nick Boldt <nboldt at redhat.com> wrote:
> Currently, when you build with -DskipTests, the baseline checks are
> also skipped.
>
> This means that if you make a change to a file in a plugin, and build
> it locally to see if anything breaks, but forget to bump the version
> of the plugin and its containing feature, you won't see the baseline
> check failure until it's built in Jenkins and someone like me
> complains about it to you directly. Using Jenkins to discover these
> problems is slow and can cause downstream jobs to fail too (if you're
> for example changing things in multiple inter-dependent projects)
>
> This happened recently in the 4.4.x branch for changes to openshift
> and base, leading to broken builds and time wasted investigating why
> the builds had failed.
>
> So I propose this change in parent pom for 4.4.x and master branches:
>
> -
> <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> +               <skipBaselineComparison>false</skipBaselineComparison>
>
> Please provide your +1/-1 on this JIRA:
>
> https://issues.jboss.org/browse/JBIDE-24114
>
>
> --
> Nick Boldt :: JBoss by Red Hat
> Productization Lead :: JBoss Tools & Dev Studio
> http://nick.divbyzero.com



-- 
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com