[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-854) our adapter uses different vm-install constant than other servers

[Rob Stryker (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBIDE-854?page=all ]

Rob Stryker resolved JBIDE-854.
-------------------------------

    Resolution: Won't Fix

unless there's a bug this is merely stylistic. When writing the adapter from scratch I did not compare with other adapters and used my own constants. So long as I used the same constnats in all places, it doesn't matter at all what the value of that constant is. 

If there's some coding standard in terms of using lower-case text I should be aware of, I'd love to hear it. If I'm not violating any coding standards that we've developed, though, I don't see the relevance of what I choose my constants to be. 

If there's an actual bug, such as the proper vm not being used during launch, feel free to create another issue declaring such. 

> our adapter uses different vm-install constant than other servers
> -----------------------------------------------------------------
>
>                 Key: JBIDE-854
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-854
>             Project: JBoss Tools
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 2.0.0.Beta3
>            Reporter: Max Andersen
>         Assigned To: Rob Stryker
>            Priority: Minor
>
> Just wondering why we use 
> public static String PROPERTY_VM_ID = "PROPERTY_VM_ID";
> public static String PROPERTY_VM_TYPE_ID = "PROPERTY_VM_TYPE_ID";
> 	
> when both tomcat and all generic servers uses
> protected static final String PROP_VM_INSTALL_TYPE_ID = "vm-install-type-id";
> protected static final String PROP_VM_INSTALL_ID = "vm-install-id";
> ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira