[jbosstools-issues] [JBoss JIRA] Reopened: (JBIDE-1544) When a "Default Schema" is specified Seam generates a project with errors

[Max Andersen (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBIDE-1544?page=all ]

Max Andersen reopened JBIDE-1544:
---------------------------------

      Assignee: Denis Golovin
             
damn - I'm blind.

JBoss Tools is replacing blindly with schema/catalog name instead of doing as seam-gen does:

<condition property="schema.property" value="&#xa;         &lt;property name=&quot;hibernate.default_schema&quot; value=&quot;${hibernate.default_schema}&quot;/&gt;">
            <isset property="hibernate.default_schema"/>
        </condition>
        <condition property="schema.property" value="">
	    	<not><isset property="hibernate.default_schema"/></not>
		</condition>
		
		<condition property="catalog.property" value="&#xa;         &lt;property name=&quot;hibernate.default_catalog&quot; value=&quot;${hibernate.default_catalog}&quot;/&gt;">
		    <isset property="hibernate.default_catalog"/>
		</condition>
		<condition property="catalog.property" value="">
		    <not><isset property="hibernate.default_catalog"/></not>
		</condition>

I have no idea why i did not notice that before.

> When a "Default Schema" is specified Seam generates a project with errors
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-1544
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1544
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 2.0.0.GA
>         Environment: 32-bit Ubuntu Linux 7.10, Eclipse 3.3.1.1 (M20071023-1652), WTP 2.0.1 (v200709110510), DTP 1.5.1, JBoss 4.2.2.GA, JBoss Seam 2.0.0.GA
>            Reporter: Alexandros Karypidis
>         Assigned To: Denis Golovin
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> When creating a new "Seam Web Project", the wizard, you are prompted for the "Default Schema". If you type one instead of leaving it empty, an incorrect persistence.xml is generated (the schema name is added to the "properties" tag, outside a "property" tag). For instance, if you specify "ABC" as the schema, you would expect a persistence.xml as follows:
>       <jta-data-source>java:/gendexDatasource</jta-data-source>
>       <properties>
>          <property name="hibernate.dialect" value="org.hibernate.dialect.Oracle10gDialect"/>
>          ...
>          <property name="hibernate.default_schema" value="ABC"/>
>       </properties>
> Instead, you get:
>       <jta-data-source>java:/gendexDatasource</jta-data-source>
>       <properties>
>          <property name="hibernate.dialect" value="org.hibernate.dialect.Oracle10gDialect"/>
>          ...
>         ABC
>       </properties>
> Also, the hibernate-console.properties file does not include the schema name. One would expect it to look like this:
> #File used by hibernate tools to override <datasource> and other container specific settings in persistence.xml
> hibernate.connection.password=xxx
> hibernate.connection.username=yyy
> ...
> hibernate.default_schema=ABC
> Instead, the last line (hibernate.default_schema=ABC) is not created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira