[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-926) DataSourceXMLDeployer chooses first server that matches runtime when several may match

[Max Andersen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-926?page=comments#action_12379995 ] 
            
Max Andersen commented on JBIDE-926:
------------------------------------

I don't think we should be making the current facet more powerfull and complex.

Currently the facet is actually creating and changing things in ways that facet's are not really "allowed" to.
(e.g. creating ear's and other projects)

We should simplify this to actually be done by a more "overarching" wizard that just handles alot of these things and only let the facet do what it can do for each project type.

> DataSourceXMLDeployer chooses first server that matches runtime when several may match
> --------------------------------------------------------------------------------------
>
>                 Key: JBIDE-926
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-926
>             Project: JBoss Tools
>          Issue Type: Feature Request
>          Components: Seam
>    Affects Versions: 2.0.0.Beta3
>            Reporter: Rob Stryker
>             Fix For: 2.0.0.CR1
>
>         Attachments: screenshot-1.jpg
>
>
> It is possible that several servers may share a runtime, but have different command line arguments. 
> The DataSourceXmlDeployer class uses the following code to decide which server to publish to:
> 			IServer[] servers = ServerCore.getServers();
> 			for (IServer server : servers) {
> 				String primaryName = primaryRuntime.getName();
> 				IRuntime runtime = server.getRuntime();
> 				if(runtime!=null) {
> 					String serverName = runtime.getName();
> 					if(primaryName.equals(serverName)) {
> 						s = server;
> 					}
> 				}
> 			}
> This code will select the last server that matches the runtime. If several match, the last one is chosen. 
> Perhaps it'd be better if the Seam Project page had a section where the user could select manually which server to deploy to if several match. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira