[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1018) XML editor is not fail-safe

[Max Andersen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-1018?page=comments#action_12380385 ] 
            
Max Andersen commented on JBIDE-1018:
-------------------------------------

Could you please then try it on linux ? It fails everytime here.

Ok so WTP is to blame for writing cvc-complex-type.3.2.2 without any hints on that what means (the rest of the error is self explanatory; its just the cvc-blablah that doesn't seem to have any purpose)

In latest Seam2 svn the definition is:
<xs:element name="action">
        <xs:complexType>
            <xs:attributeGroup ref="components:attlist.action"/>
        </xs:complexType>
    </xs:element>
    <xs:attributeGroup name="attlist.action">
        <xs:attribute name="execute" use="required"/>
    </xs:attributeGroup>

So it is a change. Anyway - no matter if its a change or a user typing something illegal; our editor should not break.

> XML editor is not fail-safe
> ---------------------------
>
>                 Key: JBIDE-1018
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1018
>             Project: JBoss Tools
>          Issue Type: Bug
>          Components: Seam
>    Affects Versions: 2.0.0.Beta4
>            Reporter: Max Andersen
>         Assigned To: Viacheslav Kabanovich
>             Fix For: 2.0.0.CR1
>
>         Attachments: components.xml
>
>
> try open a seam 2 components.xml with our editor - it will fail with the stacktrace here below.
> I'm not asking you to support whatever new feature there is in seam2 components.xml that causes this - I ask to make the xml editor not crash on input that merely has syntax errors; this is something an user could have done by hand editing the file.
> java.lang.IllegalArgumentException: Argument not valid
> 	at org.eclipse.swt.SWT.error(SWT.java:3547)
> 	at org.eclipse.swt.SWT.error(SWT.java:3481)
> 	at org.eclipse.swt.SWT.error(SWT.java:3452)
> 	at org.eclipse.swt.graphics.GC.setFont(GC.java:3224)
> 	at org.eclipse.ui.forms.widgets.ExpandableComposite$ExpandableLayout.layout(ExpandableComposite.java:280)
> 	at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1337)
> 	at org.eclipse.swt.widgets.Composite.layout(Composite.java:896)
> 	at org.eclipse.swt.widgets.Composite.layout(Composite.java:854)
> 	at org.eclipse.swt.widgets.Composite.layout(Composite.java:817)
> 	at org.jboss.tools.common.editor.form.SampleErrorForm$ErrorLayout.layout(SampleErrorForm.java:367)
> 	at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1337)
> 	at org.eclipse.swt.widgets.Composite.layout(Composite.java:896)
> 	at org.eclipse.swt.widgets.Composite.layout(Composite.java:854)
> 	at org.jboss.tools.common.editor.form.SampleErrorForm.setVisible(SampleErrorForm.java:108)
> 	at org.jboss.tools.common.editor.TreeFormPage.doErrorMode(TreeFormPage.java:300)
> 	at org.jboss.tools.common.editor.TreeFormPage.setErrorMode(TreeFormPage.java:292)
> 	at org.jboss.tools.common.model.ui.editors.multipage.DefaultMultipageEditor.setErrorMode(DefaultMultipageEditor.java:59)
> 	at org.jboss.tools.common.editor.ObjectMultiPageEditor.initEditors(ObjectMultiPageEditor.java:468)
> 	at org.jboss.tools.jst.web.ui.editors.WebCompoundEditor.doCreatePages(WebCompoundEditor.java:29)
> 	at org.jboss.tools.common.editor.ObjectMultiPageEditor.createPages(ObjectMultiPageEditor.java:231)
> 	at org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:283)
> 	at org.jboss.tools.common.model.ui.editor.EditorPartWrapper.createPartControl(EditorPartWrapper.java:112)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira