[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-926) DataSourceXMLDeployer chooses first server that matches runtime when several may match

[Victor Rubezhny (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBIDE-926?page=all ]

Victor Rubezhny resolved JBIDE-926.
-----------------------------------

    Resolution: Done

Test Case:

EXECUTE: Start the Seam Project Wizard.
ASSERT: See the "Target Server" combo and "New..." button are on the first wizard page.
EXECUTE: Enter a name for the project and select (or create if needed) a Target Runtime. Leave "Target Server" field empty.
ASSERT: See an error message in the title: "Target Server cannot be empty".
EXECUTE: Select existing Target Server from the list  or create a new one by pressing "New..." button and fulfilling the "New Server" wizard (the Server Runtime is to be used as "JBoss 4.2 Runtime")
ASSERT: See the selected (created) server name is selected in the "Target Server" combo and error message disappeared.
EXECUTE: Continue fulfilling the wizard pages and press "Finish" on the last page.
ASSERT: See a number of projects is created depending on Seam Facet Settings
ASSERT: The created project is registered in the selected (created) server

> DataSourceXMLDeployer chooses first server that matches runtime when several may match
> --------------------------------------------------------------------------------------
>
>                 Key: JBIDE-926
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-926
>             Project: JBoss Tools
>          Issue Type: Feature Request
>          Components: Seam
>    Affects Versions: 2.0.0.Beta3
>            Reporter: Rob Stryker
>         Assigned To: Victor Rubezhny
>            Priority: Critical
>             Fix For: 2.0.0.CR1
>
>         Attachments: screen-shot.jpg, screenshot-1.jpg, screenshot-2.jpg
>
>   Original Estimate: 1 day
>  Remaining Estimate: 1 day
>
> It is possible that several servers may share a runtime, but have different command line arguments. 
> The DataSourceXmlDeployer class uses the following code to decide which server to publish to:
> 			IServer[] servers = ServerCore.getServers();
> 			for (IServer server : servers) {
> 				String primaryName = primaryRuntime.getName();
> 				IRuntime runtime = server.getRuntime();
> 				if(runtime!=null) {
> 					String serverName = runtime.getName();
> 					if(primaryName.equals(serverName)) {
> 						s = server;
> 					}
> 				}
> 			}
> This code will select the last server that matches the runtime. If several match, the last one is chosen. 
> Perhaps it'd be better if the Seam Project page had a section where the user could select manually which server to deploy to if several match. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira