[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1124) hibernate tools code completion are no longer available in hbm.xml editing

[Max Andersen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-1124?page=comments#action_12383544 ] 
            
Max Andersen commented on JBIDE-1124:
-------------------------------------

"Is it a strong requirement to exclude any EL CA from hbm.xml files?"

Yes - it makes *zero* sense to provide el code completion in hbm.xml files.

"This becomes as result of specifying "org.jboss.tools.common.model.ui.xml" as the highest priority content type for any xml file. 
Result: O-o-ops! You see the CA and OpenOns from the RHDS again. And no Hibernate CA."

So it seems like our xml editor is using a way too generic content type in this situation.

Couldn't we remove the hbm.xml content recognizition from the list of things that is categorized as "org.jboss.tools.common.model.ui.xml" and just in the RedHatStructuredTextViewerConfigurationXML lookup the one that org.hibernate.tools will recognize ? Afaik the rhstvcXML does not provide any additional code completion.

"I mean changing base-type="org.eclipse.core.runtime.xml" to base-type="org.jboss.tools.common.model.ui.xml" for content types. 

It will impact the hibernate xml editors when in case they will work standalone (with no JBoss Tools installed)... they will never work standalone."

No, because of three things:

0) It have worked before without this "opposite" dependency ;)

1) hibernate tools needs to be able to run standalone  (jboss tools dependency would be illogical)

2) org.jboss.tools.common.model.ui.xml shouldn't be this generic (I think Slava and I had a discussion in jira about once were we agreed that over time we should have more specific contenttypes/editors registred instead of an all generic one.





> hibernate tools code completion are no longer available in hbm.xml editing
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-1124
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1124
>             Project: JBoss Tools
>          Issue Type: Bug
>          Components: Hibernate
>            Reporter: Max Andersen
>         Assigned To: Victor Rubezhny
>             Fix For: 2.0.0.CR1
>
>
> EXECUTE: open a hbm.xml file with our structured xml editor
> ASSERT: code completion is available for classes in e.g <class name="
> This worked before, but now it seems like it is no longer picking up the hibernate tools provided extensions in the xml source editor part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira