[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-2000) License header is incorrect for new seam search features

Victor Rubezhny (JIRA) jira-events at lists.jboss.org
Tue Apr 8 13:19:54 EDT 2008


    [ http://jira.jboss.com/jira/browse/JBIDE-2000?page=comments#action_12407590 ] 
            
Victor Rubezhny commented on JBIDE-2000:
----------------------------------------

SeamSearchEngine is written like BaseSearchEngine (as an abstract class with a factory inside), but it's content is not copied from BaseSearchEngine. 

SeamQueryParticipant is realization of IQueryParticipant interface that consists of three methods. All the implementors are very similar to each other, especially in method 

/**
 * @see org.eclipse.jdt.ui.search.IQueryParticipant#estimateTick (org.eclipse.jdt.ui.search.QuerySpecification)
 */
public int estimateTicks(QuerySpecification specification) {
	return 1;
}

But, this doesn't means that this method is copied from ClassSearchParticipant or JSPQueryParticipant....

Other two methods are implemented by myself...

I don't see a copiright problem in these classes...

> License header is incorrect for new seam search features
> --------------------------------------------------------
>
>                 Key: JBIDE-2000
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-2000
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>            Reporter: Max Andersen
>         Assigned To: Victor Rubezhny
>            Priority: Critical
>             Fix For: 2.1
>
>
> SeamSearchEngine
> SeamQueryParticipant
> (and possibly more)
> looks like direct copies of some external example (@author jeremy etc.)
> We need to get the proper copyrights into those files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jbosstools-issues mailing list