[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-2046) The JSPTextEditor.getPageContext() method is called in a non-UI thread sometimes

[Snjezana Peco (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBIDE-2046?page=all ]

Snjezana Peco resolved JBIDE-2046.
----------------------------------

    Resolution: Done

Steps to reproduce:

- create a large seam project as described in http://jira.jboss.com/jira/browse/JBIDE-1479#action_12394455
- open the pdataEdit.xhtml
- edit it until the JSPTextEditor.getPageContext method is called - at that moment, it is correctly called in the UI thread
- select the WebContent directory in the Package Explorer view and choose Source>Format

After a bit, you will get the following exception :

!ENTRY org.eclipse.wst.sse.core 4 4 2008-04-11 20:00:51.500
!MESSAGE A structured model client, org.jboss.tools.jst.jsp.support.kb.WTPTextJspKbConnector$MyDocumentAdapter at 1e58d3a threw following 

exception during adapter notification (CHANGE )
!STACK 0
org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:3563)
	at org.eclipse.swt.SWT.error(SWT.java:3481)
	at org.eclipse.swt.SWT.error(SWT.java:3452)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:432)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:326)
	at org.eclipse.swt.custom.StyledText.getCaretOffset(StyledText.java:3160)
	at org.jboss.tools.jst.jsp.jspeditor.JSPTextEditor.getPageContext(JSPTextEditor.java:203)
	at org.jboss.tools.jst.jsp.jspeditor.JSPMultiPageEditor.getTaglibManager(JSPMultiPageEditor.java:661)
	at org.jboss.tools.jst.jsp.support.kb.WTPTextJspKbConnector.initTaglibPrefixes(WTPTextJspKbConnector.java:203)
	at org.jboss.tools.jst.jsp.support.kb.WTPTextJspKbConnector.invokeDelayedUpdateKnownTagLists(WTPTextJspKbConnector.java:188)
	at org.jboss.tools.jst.jsp.support.kb.WTPTextJspKbConnector$MyDocumentAdapter.notifyChanged(WTPTextJspKbConnector.java:416)
	at org.eclipse.wst.sse.core.internal.provisional.AbstractNotifier.notify(AbstractNotifier.java:201)
	at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.notify(XMLModelNotifierImpl.java:238)
	at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.notifyDeferred(XMLModelNotifierImpl.java:340)
	at org.eclipse.wst.xml.core.internal.document.XMLModelNotifierImpl.endChanging(XMLModelNotifierImpl.java:178)
	at org.eclipse.wst.xml.core.internal.document.DOMModelImpl.changedModel(DOMModelImpl.java:163)
	at org.eclipse.wst.sse.core.internal.format.AbstractStructuredFormatProcessor.formatModel

(AbstractStructuredFormatProcessor.java:373)
	at org.eclipse.wst.sse.core.internal.format.AbstractStructuredFormatProcessor.formatModel

(AbstractStructuredFormatProcessor.java:301)
	at org.eclipse.wst.sse.core.internal.format.AbstractStructuredFormatProcessor.formatFile

(AbstractStructuredFormatProcessor.java:196)
	at org.eclipse.wst.sse.ui.internal.actions.FormatActionDelegate.format(FormatActionDelegate.java:127)
	at org.eclipse.wst.sse.ui.internal.actions.FormatActionDelegate.format(FormatActionDelegate.java:146)
	at org.eclipse.wst.sse.ui.internal.actions.FormatActionDelegate.format(FormatActionDelegate.java:154)
	at org.eclipse.wst.sse.ui.internal.actions.FormatActionDelegate.process(FormatActionDelegate.java:178)
	at org.eclipse.wst.sse.ui.internal.actions.FormatActionDelegate$FormatJob.run(FormatActionDelegate.java:96)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)


> The JSPTextEditor.getPageContext() method is called in a non-UI thread sometimes
> --------------------------------------------------------------------------------
>
>                 Key: JBIDE-2046
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-2046
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 2.1.0.beta1
>            Reporter: Snjezana Peco
>         Assigned To: Snjezana Peco
>             Fix For: 2.1.0.cr1
>
>
> While I was testing JBIDE-2045, I noticed that the JSPTextEditor.getPageContext() method was called in a non-UI thread sometimes what could crash Eclipse.
> The crash can happen when a file is updated out of the VPE (formating, validating...).
> I will fix this issue by wrapping this method in display.syncExec().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira