[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-2699) Patches for archives.core and archives.webtools

[Rob Stryker (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12427016#action_12427016 ] 

Rob Stryker commented on JBIDE-2699:
------------------------------------

Patch number 1 is a hack and has not been accepted. 
While firstly I am unable to replicate this NPE, that's never stopped them from existing before ;)  
So I looked extensively through the code and I cannot spot a place where they are caused.

I do not think the code should be forced to null-check everywhere, so the logical place to catch this NPE is in the ArchiveFilesetImpl when it is created / gotten from the DirectoryScannerExtension.

However, I cannot find a place in either of those two classes where the null value could be created. Each new DirectoryScannerExtension creates its own matchingPaths and matchedMap.

Find any code in these two classes that could cause that null, and I'll apply any patch that fixes it ;)  Let's do this properly. 



> Patches for archives.core and archives.webtools
> -----------------------------------------------
>
>                 Key: JBIDE-2699
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-2699
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Archives
>    Affects Versions: 3.0.0.alpha
>            Reporter: Marshall Culpepper
>            Assignee: Rob Stryker
>         Attachments: archives.core.patch.txt, archives.webtools.patch.txt
>
>
> I've created two patches from some changes I made in my local environment:
> - Changed the archives.webtools plugin to use J2SE-1.5 Execution Environment and the classpath to use a 1.5 compiler (it was setup for 1.6 for some reason?)
> - Exported all packages from archives.webtools plugin so code in this plugin can be used/extended
> - Made some NPE bug fixes when a fileset's matched files were empty in EventManager and ModelTruezipBridge
> If it pleases the Archives God, I submit these patches for inclusion in trunk ;)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira