[jbosstools-issues] [JBoss JIRA] Created: (JBIDE-3340) java.lang.StackOverflowError when delete value in CSS Class Dialog in width field under Linux and OS X

[Maxim Areshkau (JIRA)]

java.lang.StackOverflowError when delete value in CSS Class Dialog in width field under Linux and OS X
------------------------------------------------------------------------------------------------------

                 Key: JBIDE-3340
                 URL: https://jira.jboss.org/jira/browse/JBIDE-3340
             Project: Tools (JBoss Tools)
          Issue Type: Bug
    Affects Versions: 3.0.0.cr1
         Environment: OS Linux, OS X
            Reporter: Maxim Areshkau
            Assignee: Igor Zhukov
            Priority: Critical
             Fix For: 3.0.0.cr1


        extWidthCombo.addModifyListener(new ModifyListener() {
                public void modifyText(ModifyEvent event) {
                    String width = widthText.getText();
                    if (width != null && !width.trim().equals(Constants.EMPTY)) {
                        String tmp = extWidthCombo.getText();
                        if (tmp != null) {
                            styleAttributes.addAttribute(CSSConstants.WIDTH, width + tmp);
                        }
                    } else {
                    	extWidthCombo.select(0);
                    	return;
                    }
                    if (!updateDataFromStyleAttributes) {
                    	notifyListeners();
                    }
                }
            });
Error in else block, we in modify listener modify value so it's caused stack overflow.
Also we should remove copy/past code. Code in ModifyListener always equals or almost equals to other modify listeners for combo attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira