[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1479) Studio crush during formatting.

[Snjezana Peco (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-1479?page=comments#action_12394455 ] 
            
Snjezana Peco commented on JBIDE-1479:
--------------------------------------

In order to reproduce the issue, you can try the following test case:

- create a Seam project
- import all the files from http://jira.jboss.com/jira/secure/attachment/12315941/JBIDE-675.tar.gz to the WebContent directory
This step has to be repeated if you want to reproduce the issue after formatting
- open employee.xhtml  or pdataEdit.xhtml
- select the opened file or WebContent directory in the Package Explorer and choose Source>Format

You will get one of the following issues:

- Eclipse crashes
- Eclipse freezes
- the Visual Editor breaks (the visual part is empty)

Closing/opening  the VPE editor doesn't help. The Mozilla browser is broken  (it takes forever to load). You have to restart Eclipse.

The problem is that the "Format" action notifies INodeAdapter in the non-UI thread.
The solution is to call VpeController.notifyChanged in the UI thread (Display.async).

However, there are some more issues. They are the following:

- The OverviewRuler.redraw() method calls the StyledText.getLineAtOffset() method with an incorrect offset. I have fixed this in the way
the FreeCaretStyledText.redrawRange() method is fixed.
- if the opened file is large (employee.xhtml) and you format the WebContent directory, the "Format" action will send a lot of events and Eclipse will freeze
I have fixed this issue in the following way (there are probably some other ways to solve it) :
VpeController.notifyChanged is executed in the UIJob. The job is scheduled to be run after1000 ms delay. The old job is canceled if a new job needs to be started within 1000 ms.
A job flooding is avoided in this way. 

> Studio crush during formatting.
> -------------------------------
>
>                 Key: JBIDE-1479
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1479
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 2.0.0.GA
>         Environment: WindowsXP SP2
> jbds-win32-1.0.0.GA.jar
> JBoss Developer Studio
> Version: 1.0.0.GA
> Build: 1.0.0.GA
> JDK 1.5_08
>            Reporter: Aliaksey Nis
>         Assigned To: Sergey Vasilyev
>             Fix For: 2.0.1
>
>         Attachments: crush.JPG
>
>
> 1. Create JSFKickStart project (or Seam project)
> 2. Open inputUserName.jsp (or any xhtml in Seam)
> 3. In Package Explorer set focus on WebContent 
> 4. Call menu (Right mouse click) and select Source->Format 
> 5. During formatting click in opened in VPE page. Studio crashes.
> Its appears during one  of validation stages. So click some times during formatting, and see crash.
> Screenshot attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira