[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1479) Studio crush during formatting.

[Snjezana Peco (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-1479?page=comments#action_12395769 ] 
            
Snjezana Peco commented on JBIDE-1479:
--------------------------------------

I have reviewed the modified patch on svn. It solves the basic issue.
You haven't applied org.jboss.tools.common.text.xml.patch that fixes the following exception in the StyledWdiget class:

Caused by: java.lang.IllegalArgumentException: Index out of bounds
    at org.eclipse.swt.SWT.error(SWT.java:3547)
    at org.eclipse.swt.SWT.error(SWT.java:3481)
    at org.eclipse.swt.SWT.error(SWT.java:3452)
    at org.eclipse.swt.custom.StyledText.getLineAtOffset(StyledText.java:3399)
    at org.eclipse.jface.text.source.OverviewRuler.doPaint1(OverviewRuler.java:734)
    at org.eclipse.jface.text.source.OverviewRuler.doubleBufferPaint(OverviewRuler.java:558)
    at org.eclipse.jface.text.source.OverviewRuler.redraw(OverviewRuler.java:784)
    at org.eclipse.jface.text.source.OverviewRuler.access$2(OverviewRuler.java:778)
    at org.eclipse.jface.text.source.OverviewRuler$1.run(OverviewRuler.java:387)
    at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123)
    ... 23 more

The steps to reproduce the exception:
- create Seam project
- import all the files from http://jira.jboss.com/jira/secure/attachment/12315941/JBIDE-675.tar.gz to the WebContent directory
This step has to be repeated if you want to reproduce the issue after formatting
- open pdataEdit.xhtml
- select pdataEdit in the Package Explorer and choose Source>Format

I also suggest adding the following code to the start of the notifyChanged method :

                Display display = null;
		if (PlatformUI.isWorkbenchRunning())
			display= PlatformUI.getWorkbench().getDisplay();
		
		if (display != null && (Thread.currentThread() == display.getThread())) {
			notifyChangedInUiThread(notifier, eventType, feature, oldValue, newValue, pos);
			return;
		} 

In this way, the UIJob will start only if notifyChanged is called in non-UI thread what introduces minimal changes.
Without adding this code, you will notice a delay of 1 sec when typing in the source editor.

> Studio crush during formatting.
> -------------------------------
>
>                 Key: JBIDE-1479
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1479
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 2.0.0.GA
>         Environment: WindowsXP SP2
> jbds-win32-1.0.0.GA.jar
> JBoss Developer Studio
> Version: 1.0.0.GA
> Build: 1.0.0.GA
> JDK 1.5_08
>            Reporter: Aliaksey Nis
>         Assigned To: Maxim Areshkau
>             Fix For: 2.0.1
>
>         Attachments: crush.JPG, hs_err_pid1912.log, org.jboss.tools.common.text.xml.patch, org.jboss.tools.vpe1.patch
>
>
> 1. Create JSFKickStart project (or Seam project)
> 2. Open inputUserName.jsp (or any xhtml in Seam)
> 3. In Package Explorer set focus on WebContent 
> 4. Call menu (Right mouse click) and select Source->Format 
> 5. During formatting click in opened in VPE page. Studio crashes.
> Its appears during one  of validation stages. So click some times during formatting, and see crash.
> Screenshot attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira