[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-2385) Project Archives War archive creation(zip and exploded) with same names.

[Rob Stryker (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-2385?page=comments#action_12418300 ] 
            
Rob Stryker commented on JBIDE-2385:
------------------------------------

Just to comment a bit more, you're doing something that will specifically and obviously cause an error. While it's good that you're testing the non-happy path, the question is how should this wizard end gracefully?

Unfortunately, validation of new nodes can only truly occur upon a save at this point, and so when the save fails (which is after finish is pressed), there's no opportunity to abort the finish. So all it really can do is log the error and move forward. 

> Project Archives War archive creation(zip and exploded) with same names.
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-2385
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-2385
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Archives
>    Affects Versions: 2.1.2
>         Environment: WindowsXP SP2
> JBoss Tools 2.1.2GA 
> JBossTools-200806182342-nightly-ALL-win32.zip
>            Reporter: Aliaksey Nis
>         Assigned To: Rob Stryker
>             Fix For: 3.0.0.alpha
>
>
> EXECUTE: Create Seam War project with name "test".
> EXECUTE: Open Project archives view.
> EXECUTE: Select Seam project in Package explorer.
> EXECUTE: In Projects Archives view - New archive > WAR > zipped. Archive name default(test.war), destination folder - default(test).
> ASSERT: Archive created successfully.
> EXECUTE: In Projects Archives view - New archive > WAR > exploded. Archive name default(test.war), destination folder - select "test" in workspace. press Finish.
> FAILURE: Exception appears in error log, and no sights of archive...
> Error Completing Wizard
> org.jboss.ide.eclipse.archives.core.model.ArchivesModelException: Unable to add child node
> 	at org.jboss.ide.eclipse.archives.core.model.internal.ArchiveNodeImpl.addChild(ArchiveNodeImpl.java:263)
> 	at org.jboss.ide.eclipse.archives.core.model.internal.ArchiveNodeImpl.addChild(ArchiveNodeImpl.java:245)
> 	at org.jboss.ide.eclipse.archives.ui.wizards.AbstractArchiveWizard$1.run(AbstractArchiveWizard.java:105)
> 	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:113)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira