[jbosstools-issues] [JBoss JIRA] Commented: (JBDS-259) JBDS1.0 Massive Memory Leak using JBoss Tool HTML Editor on .XHTML files

[Snjezana Peco (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBDS-259?page=comments#action_12401691 ] 
            
Snjezana Peco commented on JBDS-259:
------------------------------------

I can reproduce this case (including note 2) in JBoss Tools 2.0.0 
The issue doesn't exist in the latest CVS. it has been fixed within JBIDE-1105.

However, there is a memory leak when entering some jsf html tag (<h:form>, for instance). The memory is released when clicking Refresh or closing the editor.
This leak is caused by the VpePageContext.addBundleDependency(Element sourceNode) method. The Element  class doesn't implement equals/hashCode and the bundleDependencySet set will be continuously increasing until the user clicks Refresh or closes the editor (calling the VpeVisualDomBuilder.rebuildDom() method).
Attached is a patch for this issue.

I have also noticed that there is a leak when dragging an element from the palette to the source editor.
I haven't found a test case for this issue yet, but will try to find and fix it.

> JBDS1.0 Massive Memory Leak using JBoss Tool HTML Editor on .XHTML files
> ------------------------------------------------------------------------
>
>                 Key: JBDS-259
>                 URL: http://jira.jboss.com/jira/browse/JBDS-259
>             Project: Developer Studio
>          Issue Type: Bug
>          Components: visualeditor
>    Affects Versions: 1.0.0.GA
>         Environment: * Windows XP Professional
> * Fresh installation of JBDS 1.0, no additional plugins/features updates etc.
> * Working from a freshly seam-gen generated project
>            Reporter: Andy Conn
>         Assigned To: Max Andersen
>         Attachments: display.xhtml, edit.xhtml, menu.xhtml, NewPartDetail.xhtml, template.xhtml
>
>
> Please refer to the disucssion @  http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4134003#4134003
> Original Post:
> There seems to be a major memory leak making the JBoss HTML Editor completely unusable.
> Mem usage in Task Manager shows as follows:
> * 111,448 On a fresh open of Jboss Dev Studio
> * 189,144 Opening an .xhtml file (in visual/source mode) using in the "Jboss HTML Editor"
> * 197,932 Removed a blank line from the source & saved
> * 207,180 Inserted a blank line in source & saved
> * 211,168 Inserted a space in source & saved
> * 357,392 Inserted & Deleted a blank line in source: repeat 20x (no saves in between)
> Clearly there is some dramatic memory problem here.
> Note:
> 1) The problem does not seem to occur when mode is set to "Source"
> 2) The memory is not released even if the HTML Editor is closed 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira