[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3101) Project Archives should ask before first build

[Rob Stryker (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12439014#action_12439014 ] 

Rob Stryker commented on JBIDE-3101:
------------------------------------

The archives builder is *just another builder*.  It's really no different than the JDT builder or any other builder.

If you do not want the builder enabled, you can go disable it. It already has a place in preferences to disable the builder.  That is in window -> preferences -> Project Archives.

I have a question. Would you expect the Java Builder to similarly pop up a dialog box when importing a large project from SVN and say "compiling all this code may take a while... are you sure?"

The fact is there's no easy way, from the builder thread, to pause and pop up a dialog box. In fact, it pretty much violates the natural flow of eclipse. The proper way to disable a builder is through its own preference page, or, if you'd like to disable all builders, that's done via Preferences > Workbench > Build automatically

As far as I know, the archives builder is *never* run from the UI thread anymore. It is invoked as just another builder. Any specific case where it is invoked directly from UI is a bug and a specific use case would be appreciated.

I'm going to leave this bug open for another day or two while I test some use-cases, but other than that I suggest you read up a bit on builders in eclipse. http://www.eclipse.org/articles/Article-Builders/builders.html

I like to imagine the archives builder is exactly like the JDT builder, and if it would be inappropriate for the JDT builder to pop up a dialog, then I would say a dialog would also be inappropriate for the archives builder. 

Regarding canceling, since the build event is run as a workspace job, you can cancel it via the Progress view. I do admit, however, that I may need to add some code to verify the monitor has not been canceled yet. 

> Project Archives should ask before first build 
> -----------------------------------------------
>
>                 Key: JBIDE-3101
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3101
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Archives
>    Affects Versions: 2.1.2
>            Reporter: Francisco Jose Peredo Noguez
>            Assignee: Rob Stryker
>             Fix For: 3.0.0.cr1
>
>
> Project Archives option should not run automatically, currently it seems to run whenever the project is rebuilt, and since by default eclipse is configured to "build automatically" each time one saves, the extra burden of having to generate .war/ear/.jar/ files makes eclipse unusable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira