[jbosstools-issues] [JBoss JIRA] Closed: (JBIDE-3164) Need validation for CSS class dialog

[Igor Zhukov (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Zhukov closed JBIDE-3164.
------------------------------

    Resolution: Done
      Assignee: Yura Zhishko  (was: Igor Zhukov)


Fixed in revision 12037.
"Finish" button is disabled in two cases:
1. CSS file path is empty
2. CSS class name is empty

> Need validation for CSS class dialog
> ------------------------------------
>
>                 Key: JBIDE-3164
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3164
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.0.0.beta1
>            Reporter: Yura Zhishko
>            Assignee: Yura Zhishko
>             Fix For: 3.0.0.cr1
>
>
> Test case:
> 1) Open CSS class dialog to create a new CSS class, do not check anything
> 2) Press Finish button
> Exeption appears:
> java.lang.NullPointerException
> at org.jboss.tools.jst.jsp.outline.cssdialog.CSSClassDialog.saveChanges(CSSClassDialog.java:248)
> at org.jboss.tools.jst.web.ui.wizards.css.NewCSSClassWizard$NewCSSClassWizardPage.saveChanges(NewCSSClassWizard.java:91)
> at org.jboss.tools.jst.web.ui.wizards.css.NewCSSClassWizard.performFinish(NewCSSClassWizard.java:55)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:742)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:373)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
> at org.eclipse.jface.window.Window.open(Window.java:801)
> at org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:253)
> at org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:273)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:281)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
> at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
> at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:472)
> at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:824)
> at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:882)
> at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:571)
> at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:512)
> at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:127)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1184)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1002)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1027)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1012)
> at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1040)
> at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1036)
> at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1352)
> at org.eclipse.swt.widgets.Control.WM_CHAR(Control.java:3894)
> at org.eclipse.swt.widgets.Canvas.WM_CHAR(Canvas.java:341)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:3787)
> at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:337)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:4528)
> at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
> at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2371)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3420)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2382)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2346)
> at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:386)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1236)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1212) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira