[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1913) Hibernate Code Generation - properties setup special editors

[Dima Geraskov (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12431096#action_12431096 ] 

Dima Geraskov commented on JBIDE-1913:
--------------------------------------

1) When I edit a path the previous value in there is not shown in the editor.
Not only the path, but all other values too. 
Fixed.

2) If the path contains unknown paths it removes them without warning
(this is most an issue when I use eclipse variables in the path).
 a) We can change Browse button functional to work as add button (oldPath+;newPath), 
 b) or show the message: "Paths "c:\dfdf, d:\dfdf" not found" before path selection dialog shown, 
 c) or show the message: "Paths "#{dfdf}, d:\dfdf," will be deleted from 'Template path' string" after selection of new path


3) Not sure if this is an iissue, but under linux it puts : instead of ; (need to check if hibernatetools actually honors that)
I am using File.pathSeparator and think that this is better then hardcode ';' as path separator.
Comment from File.pathSeparatorChar:
The system-dependent path-separator character.  This field is
/*
     * initialized to contain the first character of the value of the system
     * property <code>path.separator</code>.  This character is used to
     * separate filenames in a sequence of files given as a <em>path list</em>.
     * On UNIX systems, this character is <code>':'</code>; on Microsoft Windows systems it
     * is <code>';'</code>.
*/
Are you agree?
But may be it requires to change parameter value parsing, I am not shure too and will see if you agree, and change File.pathSeparator  to hardcoded ';' if you don't agree.

4) How can I select external/non-workspace directory ? 
In now way right now. I need to add one more dialog.


> Hibernate Code Generation - properties setup special editors
> ------------------------------------------------------------
>
>                 Key: JBIDE-1913
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-1913
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Hibernate
>            Reporter: Vitali Yemialyanchyk
>            Assignee: Dima Geraskov
>            Priority: Minor
>             Fix For: 3.0.0.beta1
>
>         Attachments: screenshot-1.jpg
>
>
> for example if the property is directory - should be posible to browse directories

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira