[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3968) Create unittests for dali integration

[Max Rydahl Andersen (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12460186#action_12460186 ] 

Max Rydahl Andersen commented on JBIDE-3968:
--------------------------------------------

http://fisheye.jboss.org/changelog/JBossTools?cs=14342 has nothing to do with this jira.

I see no .jar to support the jmock added in http://fisheye.jboss.org/changelog/JBossTools?cs=14344 

The test is unreadable. What does it actually test ? It is several 100's line of setup code, but no real test ?



> Create unittests for dali integration
> -------------------------------------
>
>                 Key: JBIDE-3968
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3968
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Hibernate
>            Reporter: Max Rydahl Andersen
>            Assignee: Max Rydahl Andersen
>            Priority: Blocker
>             Fix For: 3.0.1.GA, 3.1.0
>
>         Attachments: org.jboss.tools.hibernate.jpt.test.zip
>
>   Original Estimate: 1 day
>          Time Spent: 2 hours
>  Remaining Estimate: 6 hours
>
> While fixing JBIDE-3960 I wanted to verify my fixes did not break anything but I had no way of verifying this except tiny manual tests to be ready for GA.
> I also believe if we had had any trivial tests they would had prevented JBIDE-3960 since it would have showed up instantly.
> We need to add tests for the Dali integration, especially when we have funky code like reflection for Dali 2.1 and Dali 2.0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira