[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4655) Mavenized Project Examples and Seam Web Project wizard with JBoss Maven Integration facet don't work when using WTP 3.1 final

[Rob Stryker (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12481844#action_12481844 ] 

Rob Stryker commented on JBIDE-4655:
------------------------------------

First this has nothing to do with JBIDE-4507. 

This issue is a mix of my old code not following spec, because the old spec was broken or nonexistant, however now my code follows some elements of the spec.  Specifically, to get a child module's jar name, I used to just do module.getName(). This turned out to be very very wrong and I was supposed to do parentModule.getURI(childModule).   My logic in future versions has switched to do this and follow spec. 

It is now the responsibility of the parent module (WTP)  to properly return the child module's relative URI. The parent module has a few places it can check, but there's no spec or "order" in which the parent module *must* look. First it can look at the child module's component.xml for this "deploy-name" attribute. However, *no* code in WTP history has looked at this for child modules relative uri. Not in old wtp 2.0 versions, and not today in 3.x. 

The second place it could look is in the parent module's component.xml where, inside the reference, it could check for something like the following line:

<dependent-module archive-name="childWebDifferentName.war" deploy-path="/" handle="module:/resource/SomeWeb/SomeWeb">

We cannot ask WTP to fix this for us because the bug was in my old code, and not in WTP. I'm hesitant to apply any patches to my code now because now it is working as it is designed to and to add in weird nonsensical stuff just doesn't make sense. It now delegates the naming to the parent module so that the parent module can tell us the appropriate name for the child module. 

The only hope we have of fixing this is asking WTP whether the parent module should check the child module's descriptor in the event that the parent module's descriptor does not have an archive-name override listed. However I'm not even sure if this is possible to code or not. I'll have to look into it. 

However I most certainly cannot revert to just using the module's name as that was extremely incorrect behaviour. 

> Mavenized Project Examples and Seam Web Project wizard with JBoss Maven Integration facet don't work when using WTP 3.1 final
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-4655
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4655
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: maven, project-examples, UpStream
>    Affects Versions: 3.1.0.M3
>            Reporter: Snjezana Peco
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.0.2.GA, 3.1.0.M3
>
>         Attachments: test.zip, test1.zip
>
>
> Deployment has been changed between WTP 3.1M7 and WTP 3.1.0.
> WTP 3.1.0 ignores 
> <wb-module deploy-name="xxxx">
> in .settings/org.eclipse.wst.common.component

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira