[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4320) ESB Projects does not respect WTP module dependency rules

[Denny Xu (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12481931#action_12481931 ] 

Denny Xu commented on JBIDE-4320:
---------------------------------

Just looked through the patch, there are some problem in it:
1. we cannot use  PersistentProperty of project to persist any property, this would prevent sharing projects between different workspaces.
2. we cannot change the resource mappings to below:
       <wb-resource deploy-path="/" source-path="/esbcontent"/>
        <wb-resource deploy-path="/" source-path="/build/classes"/> 
the folder "/build/classes" is java project output folder and the name and the path are changeable, so if the user change the project default output folder,
how do you handle it, just test this case, the patch doesn't work.
I don't think  the old resource mapping has any problem, it's just like how WTP Web projects use  resource mappings, the reason why WTP does so 
is because of handling the case that the default java project output folder is changed after the project was created. 

the issue is that the ESB module factory doesn't act like WTP J2EE module, I just refactored the ESB module factory base on a WTP module delegate: J2EEFlexProjDeployable, so currently, the ESB module factory follows the standard way of using Virtual component.
anyway, the new ESB module delegate also extends from JBTProjectModuleDelegate and doesn't overwrite any method except the "members()".

so the new ESB module factory can work with old ESB project and also support any resource mappings that you expect.



> ESB Projects does not respect WTP module dependency rules
> ---------------------------------------------------------
>
>                 Key: JBIDE-4320
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4320
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: esb
>    Affects Versions: 3.0.0.GA, 3.0.1.GA
>         Environment: Windows XP, Eclipse Ganymede 3.4.2 (M20090211-1700)
>            Reporter: Vincent Girard-Reydet
>            Assignee: Rob Stryker
>            Priority: Blocker
>             Fix For: 3.1.0.M3
>
>         Attachments: JBIDE-4320a.patch
>
>
> It is not possible to include modules as dependencies of a JBossESB module. The expected behaviour is that ESB modules should behave as EAR modules.
> For example, if I want to mimick the webservice_consumer quickstart structure using WTP projects, I expect to end-up with 2 projects :
> - an ESB project
> - a Dynamic Web Module project, set as dependency of the ESB project
> I expect to have the .war archive copied at the root of the ESB archive, but:
> 1. it is not possible to configure dependencies with graphical tools (in the project properties)
> 2. Manually editing the org.eclipse.wst.common.component file to add the dependency solve nothing to the problem.
> The same applies for EJB/EJB3 projects (to mimick the helloworld_service quickstart), JPA projects and Utility projects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira