[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4872) Multiple issues with New hbm.xml wizard

Max Rydahl Andersen (JIRA) jira-events at lists.jboss.org
Tue Dec 1 13:34:29 EST 2009


    [ https://jira.jboss.org/jira/browse/JBIDE-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12497548#action_12497548 ] 

Max Rydahl Andersen commented on JBIDE-4872:
--------------------------------------------

Denis - the Add Class should actually not require any .java file since it could just use the classes...haven't actually tested that though ;)

Add class makes sense to me - and yes the lookup should probably be limited to the project - but then the wizard needs a project field too.

about the New ORM metadata then we got another jira for that: JBIDE-5330 - not sure if they should be merged into the same wizard, but at least the flow should be same/similar.

> Multiple issues with New hbm.xml wizard
> ---------------------------------------
>
>                 Key: JBIDE-4872
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4872
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Hibernate
>    Affects Versions: 3.1.0.M3
>            Reporter: Max Rydahl Andersen
>            Assignee: Anton Klimkovich
>            Priority: Critical
>             Fix For: 3.1.0.CR1
>
>         Attachments: changed_ui.PNG, hbmxmlwizardsuggestion.png
>
>
> Now that I can actual run the new hbm.xml wizard to completion here are a couple of issues/annoyances:
>  
> 1) There are *zero* instructions in the wizard making it rather hard for the user to actual know what is going on.
>   - first page shows a tree with no instructions of what you expect the user to do
>   - second page shows a list that can be bigger than what were selected on the first page, with no explanation on what this extra page means and there does not seem to be any way of editing anything on this page ?
>     - second page also shows a table with a (!) column that is for what ?
> 2) The first page does not take the current selection into account - i.e. if I select class Test, press New hbm.xml wizard I still have to go through *alot* of folders to locate it again to have it selected
> 3) I still think this tree is a bad first thing to show since it is not scalable beyond example projects.
> How about having a table showing the list of classes to add and then have an Add/Remove button for the items ?
> (see attached file)
> 2) The generated files got various bad defaults:
>     - the proxy attribute is set which indicates the model behind is build wrong. seems like you use the base name instead of the FQN. i.e. my.package.Product should be used instead of just Product
>   - associations have fetch="select" set; that doesn't seem like the default we want to encourage!
>  
> 3) (feature request) be able to specify the default identity strategy for int, long, etc. i.e. to avoid seeing "assigned" everywhere.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list