[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-5108) JBossRuntimeManager has hard-coded the configuration to default

[Denny Xu (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denny Xu updated JBIDE-5108:
----------------------------

    Attachment: newesbruntime.gif


the issue fixed, there are some changes below:

for user defined esb runtime from perference page, on this page, I added a *configuration* field, if the user point the home location to a Jboss AS or SOA-p, there configuration combo will list all available configurations, if the user select a standalone esb runtime location, the configuration combo will be empty and the user should ignore the field.
so that the ESB classpath container can pick up jars from specify server configuration or standalone esb runtime

when the user create ESB project wizard with a server supplied ESB runtime, ESB runtime classpath container will get configuration from the selected server runtime and then pick up jars accordingly.


> JBossRuntimeManager has hard-coded the configuration to default
> ---------------------------------------------------------------
>
>                 Key: JBIDE-5108
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5108
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: esb
>    Affects Versions: 3.1.0.M3
>            Reporter: Rob Stryker
>            Assignee: Denny Xu
>            Priority: Blocker
>             Fix For: 3.1.0.CR1
>
>         Attachments: newesbruntime.gif
>
>
> The class has the following code:
> 		IPath soapDeployPath = rtHome.append(SOAP_AS_LOCATION).append("server").append("default").append("deploy");
> 		IPath deployPath = rtHome.append("server").append("default").append("deploy");
> These are incorrect if the runtime configuration is not default or if some other preferences have been set to change the location.  You should instead adapt the IRuntime into a IJBossServerRuntime (if possible) and then call getConfigurationFullPath().append(IJBossRuntimeResourceConstants.DEPLOY);
> Also the same class has the following if statement twice:
> 		if (!esbPath.toFile().exists() || !sarPath.toFile().exists()) {
> 			esbPath = libPath.append(JBOSSESB_ESB);
> 			sarPath = libPath.append(JBOSSESB_SAR);
> 		}
> 		
> 		if (!esbPath.toFile().exists() || !sarPath.toFile().exists()) {
> 			esbPath = soapDeployPath.append(JBOSSESB_ESB);
> 			sarPath = soapDeployPath.append(JBOSSESB_SAR);
> 		}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira