[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-3355) org.jboss.tools.common.text.ext.hyperlink.AbstractHyperlink review

[Denis Golovin (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Golovin updated JBIDE-3355:
---------------------------------

    Fix Version/s: 3.2.next
                       (was: 3.1.0.GA)


> org.jboss.tools.common.text.ext.hyperlink.AbstractHyperlink review
> ------------------------------------------------------------------
>
>                 Key: JBIDE-3355
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3355
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: Cleanup
>    Affects Versions: 3.0.0.cr1
>            Reporter: Denis Golovin
>            Assignee: Denis Golovin
>             Fix For: 3.2.next
>
>
> 1. Consider using another approach instead of using snippet below in all methods:
> 	protected IFile getFile() {
> 		StructuredModelWrapper smw = new StructuredModelWrapper();
> 		try {
> 			smw.init(getDocument());
> 			return smw.getFile();
> 		} finally {
> 			smw.dispose();
> 		}
> 	}
> 2. Review static methods, as example - public static IFile getFile(IStructuredModel structuredModel) looks to compex

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira