[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3497) Error during saving JBoss AS 5.0 Server configuration

Rob Stryker (JIRA) jira-events at lists.jboss.org
Thu Feb 5 01:58:56 EST 2009


    [ https://jira.jboss.org/jira/browse/JBIDE-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12451237#action_12451237 ] 

Rob Stryker commented on JBIDE-3497:
------------------------------------

>>That doesn't sound like a safe way to guarantee the existence of that folder....what if i rename the folder ? shouldn't such checks be done on every start of the server instead ? And if the folder is missing inform/ask the user about it ?

Max, you fail to accept that I'm working in a framework where I can't just pop up dialogs to the user all the time ;)  It's not my code most of the time. I'm stuck in an approved lifecycle situation ;) What I *can* do is throw a CoreException and give a reason ;) 

As for whether it's safe, whether you use the UI (wizard page + editor) or just API to create a JBoss type server, the server listener (which responds to newly created servers) will create the important locations for .metadata area, the ones for the "inside server" option, and then ALSO create the folders designated in the server object as the "custom" deploy location (if they exist). 

After that, if you change the deploy folder, the only way to do that is through the editor, and the editor refuses to save if the folder doesn't exist, thus guaranteeing a safe choice.  

In the event that a custom non-existant folder is used, an exception will be thrown upon Deployment as is the proper response as per javadocs. 

> Error during saving JBoss AS 5.0 Server configuration
> -----------------------------------------------------
>
>                 Key: JBIDE-3497
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3497
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 3.0.0.cr1
>         Environment: Linux (Kernel 2.6.24-23), Mac OS 10.5.6
>            Reporter: Denis Golovin
>            Assignee: Rob Stryker
>             Fix For: 3.0.0.CR2
>
>         Attachments: jbossas-err.png, screenshot-1.jpg, ServerRuntiumeSaveError.png
>
>
> 1. EXECUTE: Create new Runtime/Server for JBoss 5.0
> 2. EXECUTE: Make Double click on created server in server view
> 3. ASSERT: JBoss 5.0 Overview opened in editing area
> 4. EXECUTE: Change Server name field in opened editor
> 5. ASSERT: Save action is enabled
> 6. EXECUTE: Save editor 
> 7. ASSERT: Save action is disabled and there are no errors
> now it fails on step 7 with error attached

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jbosstools-issues mailing list