[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[Denis Golovin (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12453022#action_12453022 ] 

Denis Golovin commented on JBIDE-3818:
--------------------------------------

How can that happen? 

Seam model and validation are in separate processes that are executed with the same schedule rule which means they should follow each other, right? Validation should start when seam model is built, validation job should lock certain resources in workspace until it is finished, it is guarantee that if someone tries to modify resource affected by validation, it is locked until validation is finished. 
Now it looks like something tries to modify seam model during validation, that means validation could use incomplete model and cannot guarantee right results.

Looking through code I can guess that getComponents() method is called only by clients and returned set isn't supposed for modification, that means it can return unmodified collection. It worth to do, but it will not help because something modifies wrapped set.

> ConcurrentModificationException in seam validator
> -------------------------------------------------
>
>                 Key: JBIDE-3818
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3818
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Seam
>    Affects Versions: 3.0.0.GA
>            Reporter: Denis Golovin
>            Assignee: Viacheslav Kabanovich
>            Priority: Critical
>             Fix For: 3.0.0.GA
>
>
> java.util.ConcurrentModificationException
>      [java] 	at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793)
>      [java] 	at java.util.HashMap$KeyIterator.next(HashMap.java:828)
>      [java] 	at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010)
>      [java] 	at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198)
>      [java] 	at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88)
>      [java] 	at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68)
>      [java] 	at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78)
>      [java] 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira