[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3836) ESB classpath container does not update library after container is changed

[Rob Stryker (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12453911#action_12453911 ] 

Rob Stryker commented on JBIDE-3836:
------------------------------------

I'd also like to note the following:

1) Anyone who extends this abstract class is getting 3 fields they probably have zero use for:  LIB_FOLDER, LIB_SOURCE_FOLDER, and CLASSPATH_CONTAINER_PREFIX, all of which contain values specific to the three classes originally intended for and no one else. The original 3 extenders had both their jars and their src jars in a specific place. 

2) The class is designed to pull jars from within a plugin bundle... not from outside eclipse. Methods would need to be overridden to change this behavior. 

3) 90% of the methods are tiny 1 or 2 line boiler-plate implementations of the interface. Nothing of value is added. 

4) The classpath decorations manager is storing *all* source attachments in the as.classpath bundle preferences rather than in their respective owner's plugins. 

5) I think it's kinda ridiculous that it's being used by so many others. Much refactoring needs to be done to bring those classes up to a versatility level that it should be for having so many people use it. 

> ESB classpath container does not update library after container is changed
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-3836
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3836
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: esb
>    Affects Versions: 3.0.0.CR2
>            Reporter: Denny Xu
>            Assignee: Rob Stryker
>             Fix For: 3.0.0.GA
>
>         Attachments: org.jboss.ide.eclipse.as.classpath.core.patch, org.jboss.tools.esb.project.core.patch2
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira