[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3073) Changing home location does not take effect for deploy/launch

[Rob Stryker (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12447922#action_12447922 ] 

Rob Stryker commented on JBIDE-3073:
------------------------------------

I can come up with a fix for this... however... it will remove some user choice in customizing their launch configuration.

Currently, I set up the defaults upon creation. After that, I don't really keep much in sync. The user can change whatever they want to the launch config.  They can change the working directory, the classpath, etc. They have complete control. 

If I add this change, then the vm arg java.endorsed.dirs will *always* be linked to the runtime, no matter what the user tries to do to change it. The working directory will *always* be linked to the runtime even if the user tries to change it. And the classpath will (attemptedly) always be linked to the server. 

Also, the Tomcat server suffers from a bug which I see no around if I do what's being suggested. The bug is that the proper jars are added to the classpath, (user entries,  run.jar).  If the runtime is changed, all I can do is *add* a new entry.  The bug specifically is that if you modify the runtime's location, a new entry is added but the old one remains. So you effectively have two entries of the same jar in different folders. 

 My other option is to remove all other entries, but if the user has added something custom to his classpath, this will ruin that and the user may complain that "i just added 10 things to my classpath, then changed my runtime, and all 10 are gone!".  Clearly we'd like to avoid this.

The question is, what trumps? Keeping the launch config in sync with the runtime? Or allowing users ultimate control over their launch config? 

> Changing home location does not take effect for deploy/launch
> -------------------------------------------------------------
>
>                 Key: JBIDE-3073
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3073
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 3.0.0.beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Blocker
>             Fix For: 3.0.0.CR2
>
>
> We cannot do another release where the servers are created with hardcoded full paths instead of relative to the runtime.
> If we interpret the directories as relative (i.e. new File(runtime.getDir(), server.getDir())) then it will even be fully backwards compatible (at least on windows)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira