[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3557) Externalise English strings (move them from source code into .properties)

[Sean Flanigan (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12448195#action_12448195 ] 

Sean Flanigan commented on JBIDE-3557:
--------------------------------------

I think the Externalize Strings wizard defaults to the getString way (even for new ResourceBundles) which doesn't help!  But just to be sure, I just checked my patch again, and all the getString()s are for existing bundles.  I can tell because I named all the new bundles Messages, not UIMessages/HibernateConsoleMessages/etc.

Refactoring the Messages classes sounds like a good idea.  I don't suppose there is a refactoring which converts from getString to the Eclipse mechanism?  I can't find it.  It would require renaming some of the property keys, eg to eliminate full stops (dot characters).

> Externalise English strings (move them from source code into .properties)
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-3557
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3557
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Cleanup
>            Reporter: Sean Flanigan
>            Assignee: Sean Flanigan
>
> Much of the English text in JBoss Tools is already externalised into .properties files, but my pseudolocalisation testing [1] shows that there is still some hard-coded English text, particularly in files like plugin.xml and feature.xml, but also in parts of the Java source.
> Any such English text needs to be moved out of the source code into .properties files, and replaced by ResourceBundle lookups.  
> - In the case of plugin.xml or Java source, Eclipse's "Externalize Strings" wizard can help.  In most cases, if a plugin already has a ResourceBundle, for instance org.jboss.tools.{plugin}.Messages, it is best to reuse this bundle, rather than creating another one for each package in the bundle.  (More bundles create more work for translators.)
> - In the case of feature.xml, there doesn't seem to be an Eclipse wizard, so externalisation has to be done by hand.
> [1] Running JBoss Tools together with Eclipse's Babel langpacks, plus the JBoss Tools langpacks. http://www.jboss.org/community/docs/DOC-13256

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira