[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3073) Changing home location does not take effect for deploy/launch

Rob Stryker (JIRA) jira-events at lists.jboss.org
Thu Jan 15 22:31:04 EST 2009


    [ https://jira.jboss.org/jira/browse/JBIDE-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12448209#action_12448209 ] 

Rob Stryker commented on JBIDE-3073:
------------------------------------

Yes I can set "default" command line args and vm args without storing them in the launch configuration, however, once the user CHANGES them or ADDS to them, it must then be stored in the launch configuration. And if they THEN change the home location of their runtime, then it will blow up.

Example:
  1) Create runtime
  2) default arguments prevail, nothing is stored in launch config
  3) User adds a -Dsome.custom.param=blah to the vm args. VM args are now stored *in* the launch config
  4) User modifies runtime's home address.   Custom, modified, stored-in-the-config arguments are NOT updated.

Maybe then the user changes his -b to be customConfig, while his runtime is actually config=default.  Stuff is not in sync, user has no idea which one to change, tooling launches the server with -b = customConfig but THINKS the config is default since that's the config stored in the runtime object. 

The Tomcat server adapter forces certain fields to match the runtime... No matter what the user does. I think this is a good way to do things. Certain fields *must* match the runtime. The users are still able to add and remove arguments that the adapter doesn't concern itself with, however a few special arguments (configuration, bind address, etc) are modifiable only by changing the runtime or changing in the server editor... NOT in changing the launch config. 

> Changing home location does not take effect for deploy/launch
> -------------------------------------------------------------
>
>                 Key: JBIDE-3073
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3073
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 3.0.0.beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Blocker
>             Fix For: 3.0.0.CR2
>
>
> We cannot do another release where the servers are created with hardcoded full paths instead of relative to the runtime.
> If we interpret the directories as relative (i.e. new File(runtime.getDir(), server.getDir())) then it will even be fully backwards compatible (at least on windows)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jbosstools-issues mailing list