[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-3581) Externalise English tab names in Preferences pages

[Viacheslav Kabanovich (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viacheslav Kabanovich resolved JBIDE-3581.
------------------------------------------

    Resolution: Done


> Externalise English tab names in Preferences pages
> --------------------------------------------------
>
>                 Key: JBIDE-3581
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3581
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: common
>            Reporter: Sean Flanigan
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.1.0
>
>
> The Preferences pages "JBoss Tools/Web/Editors/JSF Flow Diagram" and "JBoss Tools/Web/JSF/Project" both use tabs to divide the configuration.  The tab names appear to be hard-coded English, based on testing with the pseudo langpacks - http://www.jboss.org/community/docs/DOC-13256 .  The tab names are "JSF Flow Diagram", "Add View", "New Project" and "Import Project".  I haven't checked all of them, but the first two tab names are found in a small number of .java and .meta files:
> /org.jboss.tools.common.model/resources/meta/studio_eclipse_option.meta
> /org.jboss.tools.jsf/src/org/jboss/tools/jsf/JSFPreference.java
> /org.jboss.tools.jsf.ui/src/org/jboss/tools/jsf/ui/preferences/JSFFlowTabbedPreferencesPage.java
> I would have externalised the English text myself (in .java, not .meta files) but it looks as if JSF_EDITOR_PATH and JSF_ADD_VIEW_PATH are used as paths within the data model, so replacing them with localised text would probably break something.
> Note: if the meta files turn out to be part of the problem, JBIDE-2969 might be relevant.
> EDIT: I have found a number of similar cases from outside JSF:
> The Struts Flow Diagram prefs page is similar, but the tab "Struts Flow Diagram" is being localised where "JSF Flow Diagram" is not.  I think that's down to the getTitle() override in org.jboss.tools.struts.ui.preferences.WebFlowTabbedPreferencesPage.Tab.  Might help with JSFFlowTabbedPreferencesPage ?  (NB:  the other tab "Add Page" is hard-coded, just like JSF Flow Diagram.)
> Then there is "JBoss Tools/Web/Struts/Automation/Resource Insets" with the hard-coded "Default Error Messages" tab.
> And the "JBoss Tools/Web/Struts/Project" page has a suspiciously similar problem to "JBoss Tools/Web/JSF/Project" with the tab names "New Project" and "Import Project".  Both cases probably need the same fix.
> In fact, it looks like all the above cases involve descendants of /org.jboss.tools.common.model.ui/src/org/jboss/tools/common/model/ui/preferences/TabbedPreferencesPage, so I'm moving this jira out of the JSF component into common.
> If I am understanding the situation correctly, TabbedPreferencesPage needs to distinguish between model paths (to be kept as they are) and tab names (to be translated from English to other languages, ie externalised).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira