[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3642) Portlet Tools hardcode "default" for configuration name

[Snjezana Peco (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12449931#action_12449931 ] 

Snjezana Peco commented on JBIDE-3642:
--------------------------------------

These constants are used to check if a JBoss Server has portal deployer. If portal deployer exists, the portlet facet adds the portlet-api library to the classpath container.
Within the JBoss Portal server Comunity Edition/JBoss Portletcontainer, portal deployer exists only in the default configuration.

If we use "programmatic" configuration (Rob's proposal) for testing portlet capabilities and adding the library, the JBoss Portal Server with all and minimal configuration won't be recognized as a portlet capable portal server. The portlet-api library won't be added to the container. 
If we use "hard-coded" configuration (the default conf.), the JBoss Portal server will always be recognized as portlet capable, but deployment will fail in case of using all/minimal configuration.
There is yet another use case :
- create the JBoss Portal server with the default configuration (portlet deployer exists)
- add some portlet
- change the configuration to minimal (portlet deployer doesn't exist)

If we use "programmatic" configuration, the classpath container will be invalidated (the classpath container won't contain the portlet-api library); the project will have compile errors. If we use "hard-coded" configuration, the project will be compiled, but deployment will fail.

I am not sure which of these two methods is better.

As to the EPP distribution, there is portlet deployer in all,default and production configuration. The Portlet facet won't recognize portal deployer because it is placed in jboss-portal-ha.sar. I will create a new jira for this issue.

> Portlet Tools hardcode "default" for configuration name
> -------------------------------------------------------
>
>                 Key: JBIDE-3642
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3642
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Portal
>    Affects Versions: 3.0.0.cr1
>            Reporter: Rob Stryker
>            Assignee: Snjezana Peco
>
> IPortletConstants hardcode "default" as the configuration name in several constants. This is bad. These constants are used by PortletRuntimeComponentProvider and PortletRuntimeLibrariesContainerInitializer. 
> The PortletRuntimeComponentProvider should be checking the actual runtime configuration by adapting it to a IJBossServerRuntime and using hte getJBossConfiguration() method to find out what configuration the runtime represents (default, all, minimal, production)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira