[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4102) VPE refresh is too long while comments are being edited.

[Denis Maliarevich (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12474496#action_12474496 ] 

Denis Maliarevich commented on JBIDE-4102:
------------------------------------------

When comment is updated event indicating that node's structure was changed is sent, than comment's parent node gets updated along with it's parent if needed. Updating of the node consists of deleting the old visual element, deleting source node from the dom mapping, creating a new visual node based on the changed source node, creating the new dom mapping.

In the attached page after updating comment that is in ui:decorate tag ui:decorate gets updated together with parent ui:composition, and ui:decorate contains a lot of other tag inside so all of them have to be recreated too during creating of the new visual element for the changed node. This happens on every key press, because structure is changed on every press. 

Structure of the node could be changed by different events: cut/pase, deleting, key press, inserting some tag from palette, etc. so the logic of updating the whole element is correct in general. The solution is to improve its performance for a tag with a lot of children.

> VPE refresh is too long while comments are being edited.
> --------------------------------------------------------
>
>                 Key: JBIDE-4102
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4102
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.0.0.GA
>            Reporter: Yura Zhishko
>            Assignee: Denis Maliarevich
>            Priority: Minor
>             Fix For: 3.1.0.M3
>
>         Attachments: components.xhtml, main.css, VisualUpdate.swf
>
>
> 1) Create Seam 2.0.1 project and put attached files into WebContent directory.
> 2) Open components.xhtml page in VPE.
> 3) Find any comments between tags and try to edit them.
> RESULT: VPE is being updated too long. See flash.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira