[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3373) f:facet processing for xhtml pages

[Denis Maliarevich (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12470609#action_12470609 ] 

Denis Maliarevich commented on JBIDE-3373:
------------------------------------------

Facet's rendering mechanism was changed:
 1) JSF facet are rendered to existed visual tag to avoid creation of unnecassary visual tag for facet(<div> by default) that breaks in some cases expected template layout and causes errors in applying css styles. For this matter 'VPE-FACET' attribute with specified facet name was added to suitable tamplates's visual tag. While jsf facet renders itself it looks for 'VPE-FACET' attribute and is rendered to this tag, when no such tag found facet will be created into new <div> element.
  2) Each template is responsible for specifying the right place facet should render. Facet template only looks for such a place and renders itself.

This solution also fixes rich:messages styles issue JBIDE-3287.
Changes to facet's rendering influence all other templates that use facets, templates and junits both should be updated. This would demand an amount of changes in files and tests so to my mind it's better should be done after releasing M1 and branching it.

I'll attach a patch with current changes to facet, rich:messages, h:panelGrid and some util classes to show how it works. 

> f:facet processing for xhtml pages
> ----------------------------------
>
>                 Key: JBIDE-3373
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3373
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor Templates
>    Affects Versions: 3.0.0.cr1
>            Reporter: Yura Zhishko
>            Assignee: Denis Maliarevich
>             Fix For: 3.1.0.M2
>
>
> Insert next source example code into the page:
> <h:panelGrid
> 				columns="2" border="5"  width="250"
> 				rules="all" frame="above"
> 				cellpadding="4" cellspacing="6" 
> 				bgcolor="silver"
> 				style="COLOR: #ff0080; BACKGROUND-COLOR: #ffff00; TEXT-DECORATION: underline; FONT-STYLE: italic; FONT-WEIGHT: bold; FONT-SIZE: xx-large; FONT-FAMILY: 'Arial Black';" 
> 				styleClass=""
> 				captionClass="myStyle0"
> 				columnClasses="" rowClasses="" 
> 				headerClass="" footerClass="" >
> 			<f:facet name="footer">
> 				<p>sdlfsd</p>
> 				<p>dsfjal</p>
> 				<input type="button">fsdadf</input>
> 				gkhadjksfg
> 	        </f:facet>
> 			  <h:outputText value="begin"/>
> 			</h:panelGrid>
> VPE doesn't render usuall html tags and simple text, but browsers do it. <f:facet> can content only one UIComponent for JSF and RichFaces  components.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira