[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4417) Scanning jars and using eclipses classloader is not good to do in OpenMappingFileUtilEjb3

[Max Rydahl Andersen (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12471112#action_12471112 ] 

Max Rydahl Andersen commented on JBIDE-4417:
--------------------------------------------

I understand that using Ejb3Configuration is the easy way out and it is ok for now. Just please be sure to have this well tested so when we update
hibernate jars that we check that it continues to work.

The issues are that we should not be using thread context class loader if we can avoid it (class/memory leaks, incomplete classes, etc.)
and the api used from Ejb3Configuration is not public/stable

About opening files that does not have a matching resource then you don't really have anything to open, unless it  is hbm.xml's. Show a dialog stating no matching resource for <whateveryoufound> found.


> Scanning jars and using eclipses classloader is not good to do in OpenMappingFileUtilEjb3
> -----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-4417
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4417
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Hibernate
>    Affects Versions: 3.1.0.M1
>            Reporter: Max Rydahl Andersen
>            Assignee: Vitali Yemialyanchyk
>             Fix For: 3.1.0.M2
>
>
> Why are we using the current thread classloader (eclipses classloader) and jarvisitor to load resources when Eclipse already got all this info ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira