[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3874) Maven integration

[Snjezana Peco (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12472313#action_12472313 ] 

Snjezana Peco commented on JBIDE-3874:
--------------------------------------

I have committed the initial version of the JBoss Maven integration. 

The following features have been added:
- JBoss Maven Integration facet
This facet adds Maven capabilities to the project (Maven nature, builder and classpath container). If the project contains the EJB, WAR or EAR facet, the JBoss Maven Integration facet adds the corresponding plugin.
- mavenizing a Seam Web Project
If the project contains the Seam and JBoss Maven Integration facet, the post install delegate will mavenize Seam projects. This works for the EAR and WAR configurations. I have tested this functionality using Seam 2.1.1 and JBoss EAP 4.3.3. 
 There are some changes within the seam.core and seam.ui plugins:
- no one jar is copied if there is the Maven facet
- libraries aren't added to the MANIFEST.MF of the EJB and WAR project which fixes the issues described in JBIDE-4136 and JBIDE-4166
- maven parent project is added to the build project list within the SeamProjectWizard class.

TODO:

- test different Seam and JBoss AS versions
- create an ext.point that will provide contribution of Maven dependencies in some facet; add the ext. point for the JSF, JPT, WS, Portlet facets...
- test the integration using the m2eclipse trunk (I have tested with the pre-maven-3 branch)
- internationalize the features and plugins
- add tests

Issues:

- m2eclipse configures application.xml, but doesn't configure EJB and WAR modules correctly. I have solved this by configuring application.xml within the post install delegate
- m2eclipse adds the mvel14 library to the application.xml. For now, I don't have a solution for this issue
- the mvel14 library is deployed to the EAR's root and lib directory - I am not sure why
- the application is deployed on the server before configuring projects by Maven - that's is why it is necessary to republish the application after finishing the Seam wizard
- m2eclipse creates module archive name as <artifactId>-<version>.(jar|war) for the EJB and WAR projects. It would be good if we could define this name as the project's finalName
- the WTP's "Run On Server" action doesn't work. In my opinion this is a bug in WTP because the action uses  deploy-name instead of context-root
- the original Seam wizard adds the JDT core.jar when using the WAR configuration, but doesn't add it when using the EAR configuration. I haven't added it to any configuration

> Maven integration
> -----------------
>
>                 Key: JBIDE-3874
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3874
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: common
>    Affects Versions: 3.0.0.GA
>            Reporter: Max Rydahl Andersen
>            Assignee: Snjezana Peco
>            Priority: Critical
>             Fix For: 3.1.0.M2
>
>
> It is time to make sure our stuff works well with Maven, at least to the extent that the underline runtimes support it.
> First shot would be to add an adapter that allows m2eclipse controlled projects to activate the seam features.
> That would allow us still to bundle JBoss Tools without any dependencies to m2eclipse which still seem to drag in non-compatible plugins which we need to look into before tying us to m2eclipse.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira