[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3874) Maven integration

[Snjezana Peco (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12472736#action_12472736 ] 

Snjezana Peco commented on JBIDE-3874:
--------------------------------------

> What I do not understand is why this maven facet is tied to Seam - what if this were a plain Ear, war, esb, jar, .. ?

If the Seam facet doesn't exist, the Seam Maven Version field doesn't exist. Attached is a screenshot when using the default Dynamic Web Module (containing Java and Web Module facet). This has been done in the way that the o.j.t.maven.core/ui plugins don't depend on Seam.

> Here it for me would make sense if Seam etc. projects were updated to use the library framework in WTP to say "Use Maven" and then
> as far as I understand we can make it so Maven will know to pick up the right seam version (possibly add ui for more precise selection).
> Similar setup could be used for ear, war, jsf, etc. ? 

I have planned to create an ext.point that would allow contributing Maven dependencies to the existing WTP facets (JSF,JPT...). However, this isn't possible in the Seam facet because it creates more projects. Because of this, we have to make some changes in the Seam facet (Seam wizard, delegate) which, i think, is best to do after creating this ext. point.

>>The user can also decide whether to remove WTP classpath containers (where the path starts with org.eclipse.jst) 
> Yes - again, how many are there of these which would go away if they use the library provider stuff from above ?

The Maven classpath container doesn't contain all the libraries that are contained in Server Runtime containers. That's why I added a possibility to let users to not remove WTP classpath containers.

> I also guess the JBoss AS runtimes can cause havoc ? 

Runtimes can't be removed within a facet delegate. Can be done within the Seam project wizard.

>>In case of a Seam project, packaging is related to a web project and needs to be war - we can disable this field.

> okey - which projects would it be relevant for ? 

Not sure for which projects. maybe rar, sar, some utility project. This is just an additional feature that we can remove.

> Understood - but now is the time to do bigger changes to allow things like Maven to coexist better (the older behaviour should just still be possible) 

Agree. After creating this ext. point, I will propose changes in the Seam facet/wizard.

> Doesn't Seam provide that info via their pom.xml's ? 

I suppose you mean build/*.pom.xml files within the Maven distribution. I just checked FP and Seam 2.1.1.GA. They seem to have all necessary info. Will use them.

> Yeah, the dreaded maven backward incompabilities ;( hmm - doesn't m2eclipse support specifying which maven to run with ?

> btw. why won't we just generate Maven 2.1 compatible project or ? 

Not sure if maven-ear-plugin is compatible with Maven 2.1/3.0. Will check that.

> <list of m2eclipse/maven/wtp integration problems>

> How do we go around best getting these fixed ? Create jira's for them individually and report them to m2eclipse/maven and then see if we can provide > a patch or get m2eclipse team to help fix them ? if not in jira, we won't be able to get others to chip in ;) 

I will create jiras for issues I find.

> Maven integration
> -----------------
>
>                 Key: JBIDE-3874
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3874
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: common
>    Affects Versions: 3.0.0.GA
>            Reporter: Max Rydahl Andersen
>            Assignee: Snjezana Peco
>            Priority: Critical
>             Fix For: 3.1.0.M2
>
>
> It is time to make sure our stuff works well with Maven, at least to the extent that the underline runtimes support it.
> First shot would be to add an adapter that allows m2eclipse controlled projects to activate the seam features.
> That would allow us still to bundle JBoss Tools without any dependencies to m2eclipse which still seem to drag in non-compatible plugins which we need to look into before tying us to m2eclipse.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira