[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-3519) Ctrl+Z (Undo) doesn't work properly for "Replace With" operation from context menu

Tue May 5 13:46:46 EDT 2009

     [ https://jira.jboss.org/jira/browse/JBIDE-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yahor Radtsevich resolved JBIDE-3519.
-------------------------------------

    Resolution: Done

RESOLVED

The issue has been fixed in most cases, except 'Insert Around' action (Ctrl-Z needs to be pressed twice).
The reason why 'Insert Around' action is not fixed is our insertion API (PaletteInsertHelper) which requires the node to be selected to complete the insertion.
This selection forces UndoManager to make implicit call of endCompoundChange.
It is possibly to fix this case by changing the API, but IMO it requires too big amount of work for this minor issue. Moreover changing the API is very error prone because it is used in more than ten another packages.

> Ctrl+Z (Undo) doesn't work properly for "Replace With" operation from context menu
> ----------------------------------------------------------------------------------
>
>                 Key: JBIDE-3519
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3519
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.0.0.cr1
>            Reporter: Yura Zhishko
>            Assignee: Yahor Radtsevich
>             Fix For: 3.1.0.M1
>
>
> 1) Insert next source code from into empty jsp page:
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://richfaces.org/rich" prefix="rich"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f" %>
> <html>
> 	<head></head>
> 		<body>
> 			<f:view>
> 				<h:form>
> 					<h:outputText value="next" />
> 				</h:form>
> 			</f:view>
> 		</body>
> </html>
> 3) Go to the visual pane
> 4) Right mouse click on "next" element (context menu appearing)
> 5) Choose "Replace With" option and choose any tag from palette (for example, rich:calendar)
> 6) Make Undo (Ctrl+Z)
> RESULT: Tag is deleted from visual and source panes
> 7) Make Undo again
> RESULT: Base tag <h:outputText value="next" /> appeared again
> Well, I think , in this situation base tag <h:outputText value="next" /> should be returned from the first Undo (Ctrl+Z) operation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira