[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4274) Changing web context invalidates Seam projects

Alexey Kazakov (JIRA) jira-events at lists.jboss.org
Wed May 6 08:23:46 EDT 2009


    [ https://jira.jboss.org/jira/browse/JBIDE-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12465988#action_12465988 ] 

Alexey Kazakov commented on JBIDE-4274:
---------------------------------------

It seems to be an issue of WTP.
They added new RefactoringProcessor for context root rename (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=249128) in WTP 3.0.3.
This processor initializes Rename Participants with following parameters:
element - instance of IProject
newName - <new context root>

IMO that's not correct.
So such paricipants will be affected:

   <extension
         point="org.eclipse.ltk.core.refactoring.renameParticipants">
      <renameParticipant ...
         <enablement>
	            <with variable="element">
	                <or>
	                   <instanceof value="org.eclipse.core.resources.IProject"/>
	                </or>
	            </with>
         </enablement>
      </renameParticipant>

But we can check "processorIdentifier" to avoid it. Now Seam Rename Participans is invoked by org.eclipse.jdt.ui.renameJavaProjectProcessor and org.eclipse.ltk.core.refactoring.renameResourceProcessor only.

BTW I see the same problem in Eclipse ant tools and in our Hibernate tools.
If user changes Context Root then ANT and Hibernate launching configurations will be changed and become broken.
It's easy to reproduce.
I will report it to bugzilla but may be we should check "processorIdentifier" parameter in Hibernate tools too?
Max?

> Changing web context invalidates Seam projects
> ----------------------------------------------
>
>                 Key: JBIDE-4274
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4274
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Seam
>    Affects Versions: 3.0.0.GA
>            Reporter: Snjezana Peco
>            Assignee: Alexey Kazakov
>             Fix For: 3.1.0.M1
>
>
> Steps to reproduce:
> - create a Seam EAR project
> - right-click the WAR project, select Properties>Web Project Settings
> - change Context Root
> The Seam refactoring engine will change Seam settings and you will get errors in the WAR (View Folder "/<projectname>-changed/WebContent" specified for Seam project "<projectname>" does not exist. Please correct this property in "Seam settings" page (Project->Properties->Seam Settings).) and EJB (Main Seam project "<projectname>-changed" specified for Seam project "<projectname>-ejb" does not exist.) project.
> The issue can also be reproduced in JBDS 3.0.1 and in the JBT trunk.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jbosstools-issues mailing list