[jbosstools-issues] [JBoss JIRA] Created: (JBIDE-4338) org.jboss.tools.common.util.test.HttpUtilTest are failing because of NPE when trying to get Proxy Service

[Max Rydahl Andersen (JIRA)]

org.jboss.tools.common.util.test.HttpUtilTest are failing because of NPE when trying to get Proxy Service
---------------------------------------------------------------------------------------------------------

                 Key: JBIDE-4338
                 URL: https://jira.jboss.org/jira/browse/JBIDE-4338
             Project: Tools (JBoss Tools)
          Issue Type: Task
          Components: common
            Reporter: Max Rydahl Andersen
            Assignee: Alexey Kazakov
            Priority: Blocker
             Fix For: 3.1.0.M1


The test fails for me locally too, apparently CommonPlugin instance variable is not initialized because it is never been setup to start afaics.

Any idea what caused this ? i.e. did we change the startup sequence of plugins or ? 

I would also expect the instance to be initialized in a start() method and not on the constructor which seems very non-standard way.

Last failure: http://hudson.qa.jboss.com/hudson/job/jbosstools-nightly-3.1.0.Alpha1/180/testReport/(root)/CommonAllTests/testCreateHttpClient/

And here is the NPE you can see if you remove the fail and exception handling code

java.lang.NullPointerException
	at org.jboss.tools.common.util.HttpUtil.getProxyService(HttpUtil.java:190)
	at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:144)
	at org.jboss.tools.common.util.test.HttpUtilTest.testCreateHttpClient(HttpUtilTest.java:23)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at junit.framework.TestCase.runTest(TestCase.java:164)
	at junit.framework.TestCase.runBare(TestCase.java:130)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:120)
	at junit.framework.TestSuite.runTest(TestSuite.java:230)
	at junit.framework.TestSuite.run(TestSuite.java:225)
	at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira