[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5146) xml mapping editor does not report erros against DTD, as opposed to the tree view which does.

[Elhanan Maayan (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12493667#action_12493667 ] 

Elhanan Maayan commented on JBIDE-5146:
---------------------------------------

i'm not really sure about that, i mean the tree is after all a logical represntation of the dtd, when editing the saving the tree, the assumption is that it will preserve a consistent state where the xml will still be valid, otherwise it won't persist it. giving an invalid xml in the first place invalidates that assumption and may produce and incosistent result.


> xml mapping editor does not report erros against DTD, as opposed to the tree view which does.
> ---------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-5146
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5146
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Hibernate
>    Affects Versions: 3.1.0.M4
>         Environment: windows XP sp2 , eclipse 3.5.1
> JBT build ID - 0v200910281724
>            Reporter: Elhanan Maayan
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.1.0.CR1
>
>         Attachments: Paragraph.hbm.xml, screenshot-1.jpg, screenshot-2.jpg
>
>
> i'm not sure exactly what's my version, eclispe says hibernate tools is version 3.3.0v200910281724
> the xml hibernate editor does not report required missing elements while the tree validator 
> for example:
> <?xml version="1.0" encoding="UTF-8"?>
>  
> <!DOCTYPE hibernate-mapping PUBLIC
> 		"-//Hibernate/Hibernate Mapping DTD 3.0//EN"
> 		"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
> <hibernate-mapping package="com.pnx.underwrite.bo.letters" default-cascade="evict,merge,lock" default-access="property" auto-import="true">
> 	<class name="Paragraph" table="underwrite_letter_paragraph" mutable="true" polymorphism="implicit" dynamic-update="false" dynamic-insert="false"
> 		batch-size="10" select-before-update="false" optimistic-lock="version">
> 	<cache usage="read-write" />
> 		<id name="id" type="long" access="property" unsaved-value="-1">
> 			<generator class="native" />
> 		</id>
> 		<property name="text" not-null="false" unique="false" update="true" insert="true" />
>  
> 	
> 		<property update="false" access="property" type="timestamp" name="created">
> 			<column name="CREATED" sql-type="date" />
> 		</property>
> 		<property update="true" access="property" type="timestamp" name="modified">
> 			<column name="MODIFIED" sql-type="date" />
> 		</property>
> 	
> 		<property update="true" not-null="true" access="property" type="boolean" column="DELETED" name="deleted" />
> 		
> 		<set name="templates" access="field" table="underwrite_para_temp"   >
> 			<key column="template_Prm_Ref" foreign-key="uw_fk_para"/>								
> 			<many-to-many class="Paragraph" column="paragraph_prm_ref"/>										
> 		</set>
> 	</class>
> </hibernate-mapping>
> if i remove the key columns the tree editor will report an error but the xml editor won't.
> dito with using entity references with classpath, the tree editor reports an error, while xml does not (and this time the tree editor is wrong off course).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira