[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5163) Hiberante mapping editor locks tree tab even xml is well formed but not valid

[Viacheslav Kabanovich (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12493735#action_12493735 ] 

Viacheslav Kabanovich commented on JBIDE-5163:
----------------------------------------------

Denis, this behavior was settled some time ago. Editor model (xmodel) describes all known to it xml elements and attributes and when it is modified in Tree tab, it regenerates text by its content. That means that if xml has some logic errors, which do not correspond to xmodel they will be 'fixed' in some way, sometimes unpredictable, and sometimes by just erasing unknown elements/attributes. It was agreed that such 'fixing' is nothing but damaging user's input, which (input) may be incorrect, but must be respected. Cause of incorrect xml also may be that user gets and uses a newer version of dtd of which xmodel is not aware yet, in this case automatic 'fixes' made our editor just distructive, and the current solution was a great progress. To distinguish cases in which we may still use Tree tab editing without damaging user's input from those in which we may not, could be rather sophisticated and unsafe anyway. That is why Tree tab is only open for editing when its knowledge of dtd coincides with user's input.

Denis, if you believe we must do something about this and improve behavior so that editor could resolve cases of wrong dtd without damaging text, then it is related not just to hibernate but any xml our JBoss XML Tools editor covers (so issue should be renamed); and I am afraid it cannot be fixed soon, so I would put fix version to 'later'.

> Hiberante mapping editor locks tree tab even xml is well formed but not valid
> -----------------------------------------------------------------------------
>
>                 Key: JBIDE-5163
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5163
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Hibernate
>    Affects Versions: 3.1.0.M4
>            Reporter: Denis Golovin
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.1.0.CR1
>
>
> There is no reason to block tree tab when there are validation errors. SO editor should distinguish syntax and logical errors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira