[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake
Denis Golovin (JIRA)
jira-events at lists.jboss.org
Tue Nov 10 19:59:05 EST 2009
[ https://jira.jboss.org/jira/browse/JBIDE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12494056#action_12494056 ]
Denis Golovin commented on JBIDE-3628:
--------------------------------------
That happens not because $nl$ but because you have a glaring error in NoideContribution:
54 URL iconURL = iconPath == null ? null : FileLocator.find(bundle, new Path(iconPath), null);
55 if (iconURL != null) {
56 iconURL = bundle.getEntry(iconPath);
57 icon = ImageDescriptor.createFromURL(iconURL);
58 }
why do you ask for twice for for icon URL here?
If path is "icons/file.gif" it init iconURL variable twice because FileLocator.find returns it and then it goes inside if and bundle.getEntry does the same. But if path is "$nl$/icon/file.gif" FileLocator.find returns url to icon and it is not null because it aware of $nl$ variable (as Javadoc says) and then it goes to bundle.getEntry which is oblivious to any $XX$ variables. The result is an overriding correct URL in iconURL with null.
> Plugins should be .jar's not directories for efficiency sake
> ------------------------------------------------------------
>
> Key: JBIDE-3628
> URL: https://jira.jboss.org/jira/browse/JBIDE-3628
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: Build/Releng
> Reporter: Max Rydahl Andersen
> Assignee: Denis Golovin
> Priority: Critical
> Fix For: 3.1.0.CR1
>
> Attachments: exception.log
>
>
> 65 of our plugins are bundled exploded instead of a .jar
> Some are probably just mistakes and can easily be packed others are because of legacy code assuming it can access the files directly and even store data in the plugins - that should be fixed.
> What should be fixed:
> 1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
> 2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be able to load templates from plugin jar files)
> 3. Some plug-ins contain resources registered in XML catalog
> 4. common.projecttemplates contains resources that is used as template for new projects
> 5. TBD
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbosstools-issues
mailing list