[jbosstools-issues] [JBoss JIRA] Commented: (JBDS-729) generate plugin dependencies in eclipse.ini/config.ini rather than hardcoding versions

[Denis Golovin (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBDS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12494786#action_12494786 ] 

Denis Golovin commented on JBDS-729:
------------------------------------

Build now alters original eclipse.ini and config.ini files. Issue https://jira.jboss.org/jira/browse/JBDS-729 was fixed in devstudio-3.0.0.M4 branch
For eclipse.ini build:
1. Removes -showsplash option and next line by
<replaceregexp file="${distribution.dir}/eclipse/eclipse.ini"
                    match="\-showsplash[\n\r]*org.eclipse.platform[\n\r]*" replace=""
                    />
2. Loads osgi.bundles from configuration/config.ini and adds it to vmargs as last line in eclipse.ini as Java System property
-Dosgi.bundles=${osgi.bundles},org.eclipse.equinox.transforms.xslt at 1:start,org.jboss.tools.equinox.transforms.xslt at 1:start

For configuration/config.ini it altered properties this way:
1. Finds org.eclipse.equinox.transforms.hook plug-in in eclipse/plugins and initialise transforms.hook ant property with full plug-in jar name
2. Alters config.ini as
        <propertyfile file="${distribution.dir}/eclipse/configuration/config.ini">
            <entry key="eclipse.product" value="com.jboss.jbds.product.product"/>
            <entry key="osgi.splashPath" value="platform:/base/plugins/com.jboss.jbds.product"/>
            <entry key="osgi.framework.extensions" value="reference:file:${transforms.hook}"/>
        </propertyfile>

It also handles the case of Mac OSX, where eclipse.ini file is placed in eclipse/Eclipse.app/Contents/MacOS folder. I'm going to check it tomorrow in the office on Mac.

> generate plugin dependencies in eclipse.ini/config.ini rather than hardcoding versions
> --------------------------------------------------------------------------------------
>
>                 Key: JBDS-729
>                 URL: https://jira.jboss.org/jira/browse/JBDS-729
>             Project: JBoss Developer Studio
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.1.0
>            Reporter: Nick Boldt
>            Assignee: Denis Golovin
>            Priority: Blocker
>             Fix For: 3.0.0.M4
>
>         Attachments: clipboard.txt, mylyn-context.zip
>
>
> From Denis:
> > Bumped in JBDS launch problem, the reason is - migration to Eclipse 3.5 wasn't done for installer. Fixed for linux version, but need find a way to update original config.ini/eclipse.ini files during build adding xsl.transformation  plug-ins in it without keeping a copies of ini files 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira